Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2251)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 8806021: Show dangerous file type warning on Linux and Mac. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Move the ifdef to the right location Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/download_protection_service.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc
index 0e5a2defa1b3a0e24ea3825b782bca5c941efce8..6cc4a4aa79c69b77c4e67d6cfe38eb45c70f781b 100644
--- a/chrome/browser/safe_browsing/download_protection_service.cc
+++ b/chrome/browser/safe_browsing/download_protection_service.cc
@@ -737,7 +737,14 @@ void DownloadProtectionService::CheckDownloadUrl(
bool DownloadProtectionService::IsSupportedFileType(
const FilePath& filename) const {
+ // Currently, the UI only works on Windows. On Linux and Mac we still
+ // want to show the dangerous file type warning if the file is possibly
+ // dangerous which means we have to always return false here.
+#if defined(OS_WIN)
return IsBinaryFile(filename);
+#else
+ return false;
+#endif
}
void DownloadProtectionService::CancelPendingRequests() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698