Issue 8806021: Show dangerous file type warning on Linux and Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806021: Show dangerous file type warning on Linux and Mac. (Closed)

Created:
9 years ago by noelutz

Modified:
9 years ago

Reviewers:
Randy Smith (Not in Mondays), Brian Ryner

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Show dangerous file type warning on Linux and Mac. BUG=None TEST=On linux you should see a dangerous file type warning when downloading an exe. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113126

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/safe_browsing/download_protection_service.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

noelutz

Woops. I added the ifdef at the wrong location. please take another look. Thanks, noe.

9 years ago (2011-12-05 21:58:13 UTC) #3

Randy Smith (Not in Mondays)

Ah, whooops, sorry to have passed on that. Having now checked callers for IsSupportedFileType, again ...

9 years ago (2011-12-05 22:08:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/8806021/3001

9 years ago (2011-12-06 01:08:13 UTC) #6

Change committed as 113126