Issue 8806020: Add xinput1_3.dll to checkbins' excluded_files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806020: Add xinput1_3.dll to checkbins' excluded_files (Closed)

Created:
9 years ago by scottmg

Modified:
9 years ago

Reviewers:
jschuh, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, pam+watch_chromium.org, cpu_(ooo_6.6-7.5)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add xinput1_3.dll to checkbins' excluded_files xinput1_3.dll is a Microsoft DirectX redist file. Unfortunately it's shipped without /NXCOMPAT and /DYNAMICBASE. This DLL is only be loaded when the user interacts with a gamepad. BUG=79050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113091

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/checkbins/checkbins.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jschuh

On 2011/12/05 19:20:27, scottmg wrote: lgtm (as long as we've verified this is just XP, ...

9 years ago (2011-12-05 19:24:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8806020/1

9 years ago (2011-12-05 19:29:05 UTC) #3

commit-bot: I haz the power

List of reviewers changed. cpu@chromium.org did a drive-by without LGTM'ing!

9 years ago (2011-12-05 21:44:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8806020/1

9 years ago (2011-12-05 22:07:25 UTC) #6

Change committed as 113091

Expand Messages | Collapse Messages