Issue 8806012: Hydrogen support for stack local harmony bindings in function scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806012: Hydrogen support for stack local harmony bindings in function scope. (Closed)

Created:
9 years ago by Steven

Modified:
9 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Hydrogen support for stack local harmony bindings in function scope. This is the first CL in a series that add support for the harmony scoping features to crankshaft. This CL specifically adds support for stack allocated 'let' and 'const' declared variables in function scopes. TEST=mjsunit/harmony/block-let-crankshaft.js Committed: http://code.google.com/p/v8/source/detail?r=10171

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -16 lines)			Patch
	M	src/hydrogen.cc	View		5 chunks	+35 lines, -14 lines	0 comments	Download
	M	test/mjsunit/harmony/block-let-crankshaft.js	View		1 chunk	+110 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years ago (2011-12-05 16:40:36 UTC) #2

LGTM.
It's funny how you can add functionality to Crankshaft basically by adding
bailouts :-)

http://codereview.chromium.org/8806012/diff/1/test/mjsunit/harmony/block-let-...
File test/mjsunit/harmony/block-let-crankshaft.js (right):

http://codereview.chromium.org/8806012/diff/1/test/mjsunit/harmony/block-let-...
test/mjsunit/harmony/block-let-crankshaft.js:28: // Flags: --harmony-scoping
--allow-natives-syntax --trace-bailout
I think you should remove --trace-bailout before landing this.

Expand Messages | Collapse Messages