Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/net/gaia/gaia_oauth_fetcher.cc

Issue 8806011: Make NavigationEntry and friends use content::Referrer instead of plain URLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/rlz/rlz_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/gaia/gaia_oauth_fetcher.cc
diff --git a/chrome/browser/net/gaia/gaia_oauth_fetcher.cc b/chrome/browser/net/gaia/gaia_oauth_fetcher.cc
index ce7367f32e233ae477a1b24a9f95f899fd0a80d0..4ede11e4527865e6ac390263b491ee015398498e 100644
--- a/chrome/browser/net/gaia/gaia_oauth_fetcher.cc
+++ b/chrome/browser/net/gaia/gaia_oauth_fetcher.cc
@@ -282,7 +282,7 @@ namespace {
// Based on Browser::OpenURLFromTab
void OpenGetOAuthTokenURL(Browser* browser,
const GURL& url,
- const GURL& referrer,
+ const content::Referrer& referrer,
WindowOpenDisposition disposition,
content::PageTransition transition) {
browser::NavigateParams params(
@@ -292,7 +292,7 @@ void OpenGetOAuthTokenURL(Browser* browser,
params.source_contents =
browser->tabstrip_model()->GetTabContentsAt(
browser->tabstrip_model()->GetWrapperIndex(NULL));
- params.referrer = GURL("chrome://settings/personal");
+ params.referrer = referrer;
params.disposition = disposition;
params.tabstrip_add_types = TabStripModel::ADD_NONE;
params.window_action = browser::NavigateParams::SHOW_WINDOW;
@@ -317,7 +317,8 @@ void GaiaOAuthFetcher::StartGetOAuthToken() {
OpenGetOAuthTokenURL(browser,
MakeGetOAuthTokenUrl(GaiaUrls::GetInstance()->oauth1_login_scope(),
l10n_util::GetStringUTF8(IDS_PRODUCT_NAME)),
- GURL("chrome://settings/personal"),
+ content::Referrer(GURL("chrome://settings/personal"),
+ WebKit::WebReferrerPolicyDefault),
NEW_POPUP,
content::PAGE_TRANSITION_AUTO_BOOKMARK);
popup_ = BrowserList::GetLastActiveWithProfile(profile_);
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/rlz/rlz_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698