Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: content/browser/tab_contents/navigation_controller.cc

Issue 8806011: Make NavigationEntry and friends use content::Referrer instead of plain URLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/tab_contents/navigation_controller.h" 5 #include "content/browser/tab_contents/navigation_controller.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/string_number_conversions.h" // Temporary 9 #include "base/string_number_conversions.h" // Temporary
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 pending_reload_ = NO_RELOAD; 216 pending_reload_ = NO_RELOAD;
217 } 217 }
218 } 218 }
219 219
220 bool NavigationController::IsInitialNavigation() { 220 bool NavigationController::IsInitialNavigation() {
221 return last_document_loaded_.is_null(); 221 return last_document_loaded_.is_null();
222 } 222 }
223 223
224 // static 224 // static
225 NavigationEntry* NavigationController::CreateNavigationEntry( 225 NavigationEntry* NavigationController::CreateNavigationEntry(
226 const GURL& url, const GURL& referrer, content::PageTransition transition, 226 const GURL& url, const content::Referrer& referrer,
227 content::PageTransition transition,
227 bool is_renderer_initiated, const std::string& extra_headers, 228 bool is_renderer_initiated, const std::string& extra_headers,
228 content::BrowserContext* browser_context) { 229 content::BrowserContext* browser_context) {
229 // Allow the browser URL handler to rewrite the URL. This will, for example, 230 // Allow the browser URL handler to rewrite the URL. This will, for example,
230 // remove "view-source:" from the beginning of the URL to get the URL that 231 // remove "view-source:" from the beginning of the URL to get the URL that
231 // will actually be loaded. This real URL won't be shown to the user, just 232 // will actually be loaded. This real URL won't be shown to the user, just
232 // used internally. 233 // used internally.
233 GURL loaded_url(url); 234 GURL loaded_url(url);
234 bool reverse_on_redirect = false; 235 bool reverse_on_redirect = false;
235 BrowserURLHandler::GetInstance()->RewriteURLIfNecessary( 236 BrowserURLHandler::GetInstance()->RewriteURLIfNecessary(
236 &loaded_url, browser_context, &reverse_on_redirect); 237 &loaded_url, browser_context, &reverse_on_redirect);
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 void NavigationController::TransferURL( 502 void NavigationController::TransferURL(
502 const GURL& url, 503 const GURL& url,
503 const content::Referrer& referrer, 504 const content::Referrer& referrer,
504 content::PageTransition transition, 505 content::PageTransition transition,
505 const std::string& extra_headers, 506 const std::string& extra_headers,
506 const GlobalRequestID& transferred_global_request_id, 507 const GlobalRequestID& transferred_global_request_id,
507 bool is_renderer_initiated) { 508 bool is_renderer_initiated) {
508 // The user initiated a load, we don't need to reload anymore. 509 // The user initiated a load, we don't need to reload anymore.
509 needs_reload_ = false; 510 needs_reload_ = false;
510 511
511 NavigationEntry* entry = CreateNavigationEntry(url, referrer.url, transition, 512 NavigationEntry* entry = CreateNavigationEntry(url, referrer, transition,
512 is_renderer_initiated, 513 is_renderer_initiated,
513 extra_headers, 514 extra_headers,
514 browser_context_); 515 browser_context_);
515 entry->set_transferred_global_request_id(transferred_global_request_id); 516 entry->set_transferred_global_request_id(transferred_global_request_id);
516 517
517 LoadEntry(entry); 518 LoadEntry(entry);
518 } 519 }
519 520
520 void NavigationController::LoadURL( 521 void NavigationController::LoadURL(
521 const GURL& url, 522 const GURL& url,
522 const content::Referrer& referrer, 523 const content::Referrer& referrer,
523 content::PageTransition transition, 524 content::PageTransition transition,
524 const std::string& extra_headers) { 525 const std::string& extra_headers) {
525 // The user initiated a load, we don't need to reload anymore. 526 // The user initiated a load, we don't need to reload anymore.
526 needs_reload_ = false; 527 needs_reload_ = false;
527 528
528 NavigationEntry* entry = CreateNavigationEntry(url, referrer.url, transition, 529 NavigationEntry* entry = CreateNavigationEntry(url, referrer, transition,
529 false, 530 false,
530 extra_headers, 531 extra_headers,
531 browser_context_); 532 browser_context_);
532 533
533 LoadEntry(entry); 534 LoadEntry(entry);
534 } 535 }
535 536
536 void NavigationController::LoadURLFromRenderer( 537 void NavigationController::LoadURLFromRenderer(
537 const GURL& url, 538 const GURL& url,
538 const content::Referrer& referrer, 539 const content::Referrer& referrer,
539 content::PageTransition transition, 540 content::PageTransition transition,
540 const std::string& extra_headers) { 541 const std::string& extra_headers) {
541 // The user initiated a load, we don't need to reload anymore. 542 // The user initiated a load, we don't need to reload anymore.
542 needs_reload_ = false; 543 needs_reload_ = false;
543 544
544 NavigationEntry* entry = CreateNavigationEntry(url, referrer.url, transition, 545 NavigationEntry* entry = CreateNavigationEntry(url, referrer, transition,
545 true, 546 true,
546 extra_headers, 547 extra_headers,
547 browser_context_); 548 browser_context_);
548 549
549 LoadEntry(entry); 550 LoadEntry(entry);
550 } 551 }
551 552
552 void NavigationController::DocumentLoadedInFrame() { 553 void NavigationController::DocumentLoadedInFrame() {
553 last_document_loaded_ = base::TimeTicks::Now(); 554 last_document_loaded_ = base::TimeTicks::Now();
554 } 555 }
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 // When navigating to a new page, give the browser URL handler a chance to 797 // When navigating to a new page, give the browser URL handler a chance to
797 // update the virtual URL based on the new URL. For example, this is needed 798 // update the virtual URL based on the new URL. For example, this is needed
798 // to show chrome://bookmarks/#1 when the bookmarks webui extension changes 799 // to show chrome://bookmarks/#1 when the bookmarks webui extension changes
799 // the URL. 800 // the URL.
800 update_virtual_url = true; 801 update_virtual_url = true;
801 } 802 }
802 803
803 new_entry->set_url(params.url); 804 new_entry->set_url(params.url);
804 if (update_virtual_url) 805 if (update_virtual_url)
805 UpdateVirtualURLToURL(new_entry, params.url); 806 UpdateVirtualURLToURL(new_entry, params.url);
806 new_entry->set_referrer(params.referrer.url); 807 new_entry->set_referrer(params.referrer);
807 new_entry->set_page_id(params.page_id); 808 new_entry->set_page_id(params.page_id);
808 new_entry->set_transition_type(params.transition); 809 new_entry->set_transition_type(params.transition);
809 new_entry->set_site_instance(tab_contents_->GetSiteInstance()); 810 new_entry->set_site_instance(tab_contents_->GetSiteInstance());
810 new_entry->set_has_post_data(params.is_post); 811 new_entry->set_has_post_data(params.is_post);
811 812
812 InsertOrReplaceEntry(new_entry, *did_replace_entry); 813 InsertOrReplaceEntry(new_entry, *did_replace_entry);
813 } 814 }
814 815
815 void NavigationController::RendererDidNavigateToExistingPage( 816 void NavigationController::RendererDidNavigateToExistingPage(
816 const ViewHostMsg_FrameNavigate_Params& params) { 817 const ViewHostMsg_FrameNavigate_Params& params) {
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1282 for (int i = 0; i < max_index; i++) { 1283 for (int i = 0; i < max_index; i++) {
1283 // When cloning a tab, copy all entries except interstitial pages 1284 // When cloning a tab, copy all entries except interstitial pages
1284 if (source.entries_[i].get()->page_type() != 1285 if (source.entries_[i].get()->page_type() !=
1285 content::PAGE_TYPE_INTERSTITIAL) { 1286 content::PAGE_TYPE_INTERSTITIAL) {
1286 entries_.insert(entries_.begin() + insert_index++, 1287 entries_.insert(entries_.begin() + insert_index++,
1287 linked_ptr<NavigationEntry>( 1288 linked_ptr<NavigationEntry>(
1288 new NavigationEntry(*source.entries_[i]))); 1289 new NavigationEntry(*source.entries_[i])));
1289 } 1290 }
1290 } 1291 }
1291 } 1292 }
OLDNEW
« no previous file with comments | « content/browser/tab_contents/navigation_controller.h ('k') | content/browser/tab_contents/navigation_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698