Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6675)

Unified Diff: chrome/browser/webdata/keyword_table.cc

Issue 8806009: Replaced NOTREACHED with LOG message in a couple of places (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/keyword_table.cc
diff --git a/chrome/browser/webdata/keyword_table.cc b/chrome/browser/webdata/keyword_table.cc
index 85898b8d31f63b2a09c51d31e8dbff5bf75a3f75..51c4a987f381a360647c021ee773d83baac48551 100644
--- a/chrome/browser/webdata/keyword_table.cc
+++ b/chrome/browser/webdata/keyword_table.cc
@@ -375,14 +375,14 @@ bool KeywordTable::MigrateToVersion42AddKeywordsBackupTable() {
std::string KeywordTable::GetSignatureData() {
int64 backup_value = 0;
if (!meta_table_->GetValue(kDefaultSearchIDBackupKey, &backup_value)) {
- NOTREACHED() << "Couldn't get id backup.";
+ LOG(ERROR) << "No backup id for signing.";
return std::string();
}
std::string backup_data = base::Int64ToString(backup_value);
std::string backup_url;
if (!meta_table_->GetValue(kDefaultSearchBackupKey, &backup_url)) {
- NOTREACHED() << "Couldn't get backup url";
+ LOG(ERROR) << "No backup for signing.";
return std::string();
}
backup_data += backup_url;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698