Issue 8806008: Add error messages for loading ONC files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806008: Add error messages for loading ONC files. (Closed)

Created:
9 years ago by Charlie Lee

Modified:
9 years ago

Reviewers:
kmixter1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add error messages for loading ONC files. BUG=chromium-os:19399 TEST=None TBR=kmixter@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113008

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+48 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

9 years ago (2011-12-09 00:20:55 UTC) #2

http://codereview.chromium.org/8806008/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8806008/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:11665: Network property dictionary malformed
The terminology in the ONC document is NetworkConfiguration instead of Network
(that's the specific "type" in the spec for the objects in the
NetworkConfigurations list) and Object instead of Dictionary (JSON terminology).

http://codereview.chromium.org/8806008/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:11667: <message
name="IDS_NETWORK_CONFIG_ERROR_NETWORK_EAP_DICT_MALFORMED" desc="Error for
network configuration: Network EAP dictionary malformed.">
dictionary=>object

Expand Messages | Collapse Messages