Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 8806006: Show a separator only when clicking a misspelling word. (Closed)

Created:
9 years ago by Hironori Bono
Modified:
8 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Show a separator only when clicking a misspelling word. This is another stupid mistake of mine while moving spellchecker-related context-menu to the SpellingMenuObserver class. (As written in r111881 <http://crrev.com/111881>;, the original code shows this separator only when |misspelled_word| is not empty.) This change shows this separator only when this |misspelled_word| is not empty. BUG=105926 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113124

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
Greetings Avi, Thank you for your help in advance. I notice I made another bonehead ...
9 years ago (2011-12-05 11:43:48 UTC) #1
Avi (use Gerrit)
lgtm
9 years ago (2011-12-05 13:07:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8806006/1
9 years ago (2011-12-06 00:21:42 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-06 06:18:44 UTC) #4
Change committed as 113124

Powered by Google App Engine
This is Rietveld 408576698