Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 8806001: Add test where X is defined differentlty in co-importing libraries (Closed)

Created:
9 years ago by sra1
Modified:
9 years ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test where X is defined differentlty in co-importing libraries *** Replaced by http://codereview.chromium.org/8802018/ AFAIK this should work because the imports use prefixes. Frog: passes VM: '/usr/local/google/home/sra/dart-all/dart/tests/language/src/LibrarySameNameUsedLib2.dart': Error: Class 'X' is used where an interface is expected Dartc: tests/language/src/LibrarySameNameUsedLib2.dart/LibrarySameNameUsedLib2.dart:13: no such type "lib2" 12: 13: X makeX() { return new lib2.X(); } ~~~~ tests/language/src/LibrarySameNameUsedLib2.dart/LibrarySameNameUsedLib2.dart:13: New expression does not resolve to a constructor 12: 13: X makeX() { return new lib2.X(); } ~~~~~~ BUG= TEST=

Patch Set 1 #

Patch Set 2 : fix dartc issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M tests/language/language.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedLib1.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedLib2.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedTest.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698