Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 8805024: NaCl: Update revision in DEPS, r7354 -> r7357 (Closed)

Created:
9 years ago by Roland McGrath
Modified:
9 years ago
Reviewers:
noelallen1
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r7354 -> r7357 This pulls in the following Native Client changes: r7355: (mcgrathr) Don't misalign the trusted stack on ARM r7356: (jvoung) Avoid linking in pnacl irt shim for the hello world commandline test. r7357: (mcgrathr) Harmonize flags for Linux builds BUG=none TEST=nacl_integration R=noelallen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M DEPS View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roland McGrath
9 years ago (2011-12-05 20:13:59 UTC) #1
noelallen1
Please make sure to run a try, then submit TBR.
9 years ago (2011-12-05 21:49:28 UTC) #2
Roland McGrath
tries already succeeded. I'm not entirely sure on why a comment suggesting TBR makes more ...
9 years ago (2011-12-05 21:50:26 UTC) #3
Roland McGrath
The tries that succeeded were try -t nacl_integration.
9 years ago (2011-12-05 21:54:07 UTC) #4
noelallen1
9 years ago (2011-12-05 21:58:32 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698