Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8805022: Rename constants used with default apps to confrom with naming convention. (Closed)

Created:
9 years ago by Roger Tawa OOO till Jul 10th
Modified:
9 years ago
Reviewers:
sail, Evan Stade
CC:
chromium-reviews, jstritar+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, rginda+watch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Rename constants used with default apps to confrom with naming convention. BUG=None TEST=No functionality change. Simply renaming constants.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/default_apps.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/default_apps_trial.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/default_apps_trial.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Roger Tawa OOO till Jul 10th
9 years ago (2011-12-05 19:53:14 UTC) #1
Roger Tawa OOO till Jul 10th
Hi Sailesh, Can you review the profile_manager.cc change please? I need an owner review. Thanks.
9 years ago (2011-12-05 19:57:44 UTC) #2
Aaron Boodman
Extensions bits lgtm
9 years ago (2011-12-05 20:11:41 UTC) #3
sail
lgtm
9 years ago (2011-12-05 20:13:13 UTC) #4
Evan Stade
lgtm, thanks
9 years ago (2011-12-05 20:35:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/8805022/1
9 years ago (2011-12-06 14:32:36 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-06 15:36:06 UTC) #7 
Change committed as 113205

Powered by Google App Engine
This is Rietveld 408576698