Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 8805020: Fix some mixed content warnings when accessing extension docs (Closed)

Created:
9 years ago by Aaron Boodman
Modified:
9 years ago
Reviewers:
kathyw
CC:
chromium-reviews, jstritar+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix some mixed content warnings when accessing extension docs over SSL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -420 lines) Patch
M chrome/common/extensions/docs/a11y.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/api_other.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/apps.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/autoupdate.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/background_pages.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/bookmarks.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/browserAction.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/contentSettings.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/content_scripts.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/contextMenus.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/cookies.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/crx.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/devguide.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/docs.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/events.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.app.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.clear.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.contentSettings.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.contextMenus.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.cookies.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.debugger.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.audits.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.console.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.network.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.panels.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.resources.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.history.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.infobars.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.inputUI.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.privacy.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.socket.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.speechInput.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.storage.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webInspector.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webInspector.audits.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webInspector.panels.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webInspector.resources.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/extension.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/external_extensions.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/faq.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/fileBrowserHandler.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/getstarted.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/history.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/hosting.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/i18n.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/i18n-messages.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/idle.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/index.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/management.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/match_patterns.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/messaging.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/notifications.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/npapi.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/omnibox.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/options.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/override.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/overview.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/packaging.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/pageAction.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/pageCapture.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/permission_warnings.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/permissions.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/proxy.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tabs.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/themes.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tts.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/ttsEngine.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tut_analytics.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tut_debugging.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tut_oauth.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/tutorials.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/types.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/webNavigation.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/webRequest.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/whats_new.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/windows.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/xhr.html View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
9 years ago (2011-12-05 19:43:59 UTC) #1
Aaron Boodman
Only the change to api_template.html matters.
9 years ago (2011-12-05 19:44:24 UTC) #2
kathyw
We could switch between http and https dynamically. Also, we might want to switch to ...
9 years ago (2011-12-05 19:56:20 UTC) #3
Aaron Boodman
9 years ago (2011-12-05 20:11:31 UTC) #4
On Mon, Dec 5, 2011 at 11:56 AM,  <kathyw@chromium.org> wrote:
> We could switch between http and https dynamically.

Is there any benefit? It's simpler to just always include https.

> Also, we might want to
> switch to the asynchronous analytics code, while we're in here.

I know nothing about analytics. We seem to be including both ga.js and
urchin.js, which contain the same functionality.

Do you know what's up with that?

- a

Powered by Google App Engine
This is Rietveld 408576698