Issue 8805011: Fixing MathPowHalf on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8805011: Fixing MathPowHalf on x64. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixing MathPowHalf on x64. BUG=v8:397 TEST=regress-397.js Committed: http://code.google.com/p/v8/source/detail?r=10159

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+19 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

9 years ago (2011-12-05 16:32:41 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/8805011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/8805011/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2860: // Check base for -Infinity.  According to
IEEE-754, single-precision
double-precision

Expand Messages | Collapse Messages