Issue 8805010: Fix Manifest leak in Extension::InitFromValue.

Issue 8805010: Fix Manifest leak in Extension::InitFromValue. (Closed)

Created:
9 years ago by jstritar

Modified:
9 years ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Manifest leak in Extension::InitFromValue. Extension::InitFromValue was leaking Manifest objects when returning early from error conditions. BUG=106331 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113024

Patch Set 1 #

Patch Set 2 : remove suppressions #

Patch Set 3 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -35 lines)			Patch
M	chrome/common/extensions/extension.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jstritar

(switching reviewer to antony, looks like aaron's swamped with reviews)

9 years ago (2011-12-05 18:28:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jstritar@chromium.org/8805010/2001

9 years ago (2011-12-05 18:57:01 UTC) #4

commit-bot: I haz the power

Can't apply patch for file tools/valgrind/memcheck/suppressions.txt. While running patch -p1 --forward --force; patching file tools/valgrind/memcheck/suppressions.txt ...

9 years ago (2011-12-05 18:57:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jstritar@chromium.org/8805010/1002

9 years ago (2011-12-05 19:12:51 UTC) #6

commit-bot: I haz the power

9 years ago (2011-12-05 19:12:53 UTC) #7

Can't apply patch for file tools/valgrind/memcheck/suppressions.txt.
While running patch -p1 --forward --force;
patching file tools/valgrind/memcheck/suppressions.txt
Hunk #1 FAILED at 5322.
1 out of 1 hunk FAILED -- saving rejects to file
tools/valgrind/memcheck/suppressions.txt.rej

Expand Messages | Collapse Messages