Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: dart/frog/leg/scanner/array_based_scanner.dart

Issue 8805008: Various scanner fixes: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and update language.status Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/leg/scanner/byte_array_scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/array_based_scanner.dart
diff --git a/dart/frog/leg/scanner/array_based_scanner.dart b/dart/frog/leg/scanner/array_based_scanner.dart
index 5c2a088faf29894ec3975f6c15213064932f338b..f9c61d7de3a914ea29339ffdb902dac159c989b2 100644
--- a/dart/frog/leg/scanner/array_based_scanner.dart
+++ b/dart/frog/leg/scanner/array_based_scanner.dart
@@ -83,28 +83,42 @@ class ArrayBasedScanner<S> extends AbstractScanner<S> {
groupingStack = groupingStack.prepend(token);
}
- void appendEndGroup(int kind, String value, int openKind) {
- Token oldTail = tail;
+ int appendEndGroup(int kind, String value, int openKind) {
+ assert(openKind !== LT_TOKEN);
appendStringToken(kind, value);
if (groupingStack.isEmpty()) {
- if (openKind === LT_TOKEN) return;
throw new MalformedInputException('Unmatched $value');
}
- while (openKind !== LT_TOKEN &&
- !groupingStack.isEmpty() &&
- groupingStack.head.kind === LT_TOKEN) {
+ discardOpenLt();
+ BeginGroupToken begin = groupingStack.head;
+ if (begin.kind !== openKind) {
+ if (openKind !== OPEN_CURLY_BRACKET_TOKEN ||
+ begin.kind !== STRING_INTERPOLATION_TOKEN) {
+ // Not ending string interpolation.
+ throw new MalformedInputException('Unmatched ${begin.stringValue}');
+ }
+ // We're ending an interpolated expression.
+ begin.endGroup = tail;
groupingStack = groupingStack.tail;
+ // Using "start-of-text" to signal that we're back in string
+ // scanning mode.
+ return $STX;
}
- if (groupingStack.head.kind !== openKind) {
- if (openKind === LT_TOKEN) return;
- throw new MalformedInputException('Unmatched $value');
- }
- groupingStack.head.endGroup = oldTail.next;
+ begin.endGroup = tail;
groupingStack = groupingStack.tail;
+ return advance();
+ }
+
+ void appendGt(int kind, String value) {
+ appendStringToken(kind, value);
+ if (groupingStack.isEmpty()) return;
+ if (groupingStack.head.kind === LT_TOKEN) {
+ groupingStack.head.endGroup = tail;
+ groupingStack = groupingStack.tail;
+ }
}
void appendGtGt(int kind, String value) {
- Token oldTail = tail;
appendStringToken(kind, value);
if (groupingStack.isEmpty()) return;
if (groupingStack.head.kind === LT_TOKEN) {
@@ -112,13 +126,12 @@ class ArrayBasedScanner<S> extends AbstractScanner<S> {
}
if (groupingStack.isEmpty()) return;
if (groupingStack.head.kind === LT_TOKEN) {
- groupingStack.head.endGroup = oldTail.next;
+ groupingStack.head.endGroup = tail;
groupingStack = groupingStack.tail;
}
}
void appendGtGtGt(int kind, String value) {
- Token oldTail = tail;
appendStringToken(kind, value);
if (groupingStack.isEmpty()) return;
if (groupingStack.head.kind === LT_TOKEN) {
@@ -130,7 +143,13 @@ class ArrayBasedScanner<S> extends AbstractScanner<S> {
}
if (groupingStack.isEmpty()) return;
if (groupingStack.head.kind === LT_TOKEN) {
- groupingStack.head.endGroup = oldTail.next;
+ groupingStack.head.endGroup = tail;
+ groupingStack = groupingStack.tail;
+ }
+ }
+
+ void discardOpenLt() {
+ while (!groupingStack.isEmpty() && groupingStack.head.kind === LT_TOKEN) {
groupingStack = groupingStack.tail;
}
}
« no previous file with comments | « no previous file | dart/frog/leg/scanner/byte_array_scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698