Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 8805004: Implement NPNVsupportsCompositingCoreAnimationPluginsBool (Closed)

Created:
9 years ago by stuartmorgan
Modified:
9 years ago
CC:
chromium-reviews, stuartmorgan, darin-cc_chromium.org
Visibility:
Public.

Description

Implement NPNVsupportsCompositingCoreAnimationPluginsBool Returns true when plugin compositing is enabled, so that plugins that dynamically query for composited CA support know it's safe to use CA. Updates NPAPI headers to r14 of the upstream 'npapi-sdk' project headers, to pick up the new constant. BUG=40997 TEST=HTML overlays should work with, e.g., the Google Earth plugin on 10.6+ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113370

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix missing logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M third_party/npapi/bindings/npapi.h View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/npapi/bindings/npfunctions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/bindings/npruntime.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/npapi/bindings/nptypes.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
stuartmorgan
kbr: review ananta: OWNERS check for webkit/plugins/npapi
9 years ago (2011-12-05 10:10:35 UTC) #1
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/8805004/diff/1/webkit/plugins/npapi/plugin_host.cc File webkit/plugins/npapi/plugin_host.cc (right): http://codereview.chromium.org/8805004/diff/1/webkit/plugins/npapi/plugin_host.cc#newcode856 webkit/plugins/npapi/plugin_host.cc:856: webkit::npapi::UsingCompositedCoreAnimationPlugins(); Missing 'break'
9 years ago (2011-12-05 20:22:43 UTC) #2
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/8805004/diff/1/webkit/plugins/npapi/plugin_host.cc File webkit/plugins/npapi/plugin_host.cc (right): http://codereview.chromium.org/8805004/diff/1/webkit/plugins/npapi/plugin_host.cc#newcode856 webkit/plugins/npapi/plugin_host.cc:856: webkit::npapi::UsingCompositedCoreAnimationPlugins(); On 2011/12/05 20:22:43, kbr wrote: > Missing 'break' ...
9 years ago (2011-12-05 20:23:33 UTC) #3
stuartmorgan
Sigh; not sure how I screwed that up. Coincidentally, the next block was also a ...
9 years ago (2011-12-06 14:00:53 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
9 years ago (2011-12-06 18:35:49 UTC) #5
ananta
lgtm
9 years ago (2011-12-06 19:50:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/8805004/4001
9 years ago (2011-12-06 21:15:34 UTC) #7
commit-bot: I haz the power
Try job failure for 8805004-4001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years ago (2011-12-06 21:59:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/8805004/4001
9 years ago (2011-12-07 08:35:37 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-07 10:13:59 UTC) #10
Change committed as 113370

Powered by Google App Engine
This is Rietveld 408576698