Issue 8804026: Move unrecoverable_error_handler file to util folder.

Issue 8804026: Move unrecoverable_error_handler file to util folder. (Closed)

Created:
9 years ago by lipalani1

Modified:
9 years ago

Reviewers:
rlarocque, tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This move is done so that the file could be referenced from syncable layer. This is the first patch to get remove CHECK stmts from syncable layer. BUG=100444 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113530

Patch Set 1 #

Patch Set 2 : For review. #

Total comments: 2

Patch Set 3 : For review. #

Patch Set 4 : For review. #

Patch Set 5 : Fix. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -40 lines)			Patch
M	chrome/browser/sync/glue/bookmark_model_associator.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/change_processor_mock.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/data_type_controller.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/generic_change_processor.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/shared_change_processor_mock.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/theme_change_processor.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/sync/internal_api/includes/unrecoverable_error_handler.h	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/sync/unrecoverable_error_handler.h	View		1 chunk	+0 lines, -29 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

lipalani1

whoever has the time please review this. A quick lgtm would help me delete this ...

9 years ago (2011-12-05 22:40:01 UTC) #1

rlarocque

http://codereview.chromium.org/8804026/diff/2001/chrome/chrome.gyp File chrome/chrome.gyp (right): http://codereview.chromium.org/8804026/diff/2001/chrome/chrome.gyp#newcode485 chrome/chrome.gyp:485: 'browser/sync/util/unrecoverable_error_handler.h', Do we need to remove browser/sync/unrecoverable_error_handler.h, too?

9 years ago (2011-12-05 22:51:26 UTC) #2

lipalani1

After talking to Tim moved the file to internal_api/includes. Answered Richard's question. http://codereview.chromium.org/8804026/diff/2001/chrome/chrome.gyp File chrome/chrome.gyp ...

9 years ago (2011-12-05 23:18:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/8804026/4002

9 years ago (2011-12-08 00:29:21 UTC) #5

Change committed as 113530

Expand Messages | Collapse Messages