Proper management for policy-configured networks.

Proper management for policy-configured networks.

This makes sure policy-configured networks get assigned to the correct profile. Also, they're now removed from the profile when the policy doesn't specify them any longer. Relies on the GUID fields in the network specifications, and requires https://gerrit.chromium.org/gerrit/#change,12437 on the flimflam side.

BUG=chromium-os:19411
TEST=Configure a network through policy. Remove that network and reload policy. The network should disappear from the network list.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114623

[Mattias Nissler (ping if slow), 2011-12-05 19:12:10]

Steven: Main reviewer
Julian: chrome/browser/policy
Ken: FYI

[stevenjb, 2011-12-05 20:36:37]

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2864: std::vector<Network*>
networks;
Can use ScopedVector here instead of STLDeleteElements before returning.

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2883: std::set<std::string>
network_ids;
These comments are a little confusing; the "Configure the networks" comment
appears to apply to profile_path(), and this comment looks attacked to
network_ids. Maybe combine these either before or after the variable
declarations for this section?

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2910: // networks and the actual
deletion later because ForgetNetwork() changes the
s/and the/and do the/

[Mattias Nissler (ping if slow), 2011-12-05 20:58:29]

Addressed your comments, fixed unit tests, and removed that stray file that
should have been in the other CL. PTAL. Thanks!

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2864: std::vector<Network*>
networks;
On 2011/12/05 20:36:38, Steven Bennetts wrote:
> Can use ScopedVector here instead of STLDeleteElements before returning.

Done.

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2883: std::set<std::string>
network_ids;
On 2011/12/05 20:36:38, Steven Bennetts wrote:
> These comments are a little confusing; the "Configure the networks" comment
> appears to apply to profile_path(), and this comment looks attacked to
> network_ids. Maybe combine these either before or after the variable
> declarations for this section?

Done.

http://codereview.chromium.org/8804021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:2910: // networks and the actual
deletion later because ForgetNetwork() changes the
On 2011/12/05 20:36:38, Steven Bennetts wrote:
> s/and the/and do the/

Done.

[stevenjb, 2011-12-05 22:48:02]

LGTM

[pastarmovj, 2011-12-06 08:49:03]

LGTM

[kmixter1, 2011-12-14 22:00:01]

lgtm