Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: chrome/browser/download/download_service.cc

Issue 8804018: Delay DownloadManager creation by adding a callback queue to DownloadService (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_service.cc
diff --git a/chrome/browser/download/download_service.cc b/chrome/browser/download/download_service.cc
index 2bb03ed38c26fc712bd06d5ead614f93422a80af..04693ec2170ac909102b438c52f5d5485b472617 100644
--- a/chrome/browser/download/download_service.cc
+++ b/chrome/browser/download/download_service.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/download/download_service.h"
+#include "base/callback.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/download/chrome_download_manager_delegate.h"
#include "chrome/browser/download/download_service_factory.h"
@@ -29,6 +30,15 @@ DownloadIdFactory* DownloadService::GetDownloadIdFactory() const {
return id_factory_.get();
}
+void DownloadService::OnManagerCreated(
+ const DownloadService::OnManagerCreatedCallback& cb) {
+ if (download_manager_created_) {
+ cb.Run(manager_.get());
+ } else {
+ on_manager_created_callbacks_.push_back(cb);
+ }
+}
+
DownloadManager* DownloadService::GetDownloadManager() {
if (!download_manager_created_) {
// In case the delegate has already been set by
@@ -42,6 +52,12 @@ DownloadManager* DownloadService::GetDownloadManager() {
manager_->Init(profile_);
manager_delegate_->SetDownloadManager(manager_);
download_manager_created_ = true;
+ for (std::vector<OnManagerCreatedCallback>::iterator cb
+ = on_manager_created_callbacks_.begin();
+ cb != on_manager_created_callbacks_.end(); ++cb) {
+ cb->Run(manager_.get());
+ }
+ on_manager_created_callbacks_.clear();
}
return manager_.get();
}
« no previous file with comments | « chrome/browser/download/download_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698