Reland 8688002: PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

content/renderer/render_view_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 581 matching lines @@
   WebFrame* main_frame = webview() ? webview()->mainFrame() : NULL;
   if (main_frame)
     content::GetContentClient()->SetActiveURL(main_frame->document().url());
 
   ObserverListBase<RenderViewObserver>::Iterator it(observers_);
   RenderViewObserver* observer;
   while ((observer = it.GetNext()) != NULL)
     if (observer->OnMessageReceived(message))
       return true;
 
+  // Pepper plugin delegate doesn't use observers mechanism to don't implement
+  // huge interface RenderViewObserver that receives notifications about
+  // everything.

[jam, 2011/12/05 18:07:49]

None of RenderViewObserver's virtual methods are pure by design, so that
implementors only have to override the methods they care about. Please use
RenderViewObserver here.

[Dmitry Polukhin, 2011/12/05 19:09:26]

Done but it's inefficient and creates cyclic dependency in RenderViewImpl
construction order. RenderViewObserver in constructor tries to add observer to
RenderViewImple but it is not fully constructed by that point (constructor for
observers vector was not called because it is declared below pepper_delegate_).
So I had to use NULL in RenderViewObserver and add observers manually.  I can
change member order in RenderViewImpl but it's still bad to have such
construction order dependency.

[jam, 2011/12/05 19:24:43]

I think only profiling can show us that this is slow. The reason we've split off
as much code as possible into RenderViewObservers is to avoid the previous
status quo, which was everything was being dispatched in RenderView. This made
the code very hard to understand.
I think switching the member order is better in this case (it wasn't important
before, but now it matters for this).

+  if (pepper_delegate_.OnMessageReceived(message))
+    return true;
+
   bool handled = true;
   bool msg_is_ok = true;
   IPC_BEGIN_MESSAGE_MAP_EX(RenderViewImpl, message, msg_is_ok)
     IPC_MESSAGE_HANDLER(ViewMsg_Navigate, OnNavigate)
     IPC_MESSAGE_HANDLER(ViewMsg_Stop, OnStop)
     IPC_MESSAGE_HANDLER(ViewMsg_ReloadFrame, OnReloadFrame)
     IPC_MESSAGE_HANDLER(ViewMsg_Undo, OnUndo)
     IPC_MESSAGE_HANDLER(ViewMsg_Redo, OnRedo)
     IPC_MESSAGE_HANDLER(ViewMsg_Cut, OnCut)
     IPC_MESSAGE_HANDLER(ViewMsg_Copy, OnCopy)
@@ skipping 4177 matching lines @@
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit(
     const IPC::ChannelHandle& channel_handle) {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this, channel_handle));
 #endif
 }