Move a bunch of accessibility tests in chrome that have no chrome dependencies to content. We wan...

Move a bunch of accessibility tests in chrome that have no chrome dependencies to content. We want code that tests content to live alongside the code its testing. Also, some of these depend on view_messages.h, which is internal to content.

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112988

[dmazzoni, 2011-12-05 03:39:04]

LGTM

Great!

For the remaining tests that could conceivably move, I see these dependencies,
amongst others - are any of these destined to move to content/ (or somewhere
else generic), or should we try to refactor the tests to not depend on them, or
will some tests have to remain in chrome/ ?

#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#include "chrome/test/ui/ui_test.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"

[jam, 2011-12-05 03:56:24]

On 2011/12/05 03:39:04, Dominic Mazzoni wrote:
> LGTM
> 
> Great!
> 
> For the remaining tests that could conceivably move, I see these dependencies,
> amongst others - are any of these destined to move to content/ (or somewhere
> else generic), or should we try to refactor the tests to not depend on them,
or
> will some tests have to remain in chrome/ ?

Yes we should definitely move the remaining tests :)

> 
> #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"

I couldn't move the mac one because of this, but it wasn't as urgent because it
didn't include view_messages.h. I'll defer to Mac experts on how feasible it is
to move this.

> #include "chrome/test/ui/ui_test.h"
> #include "chrome/test/base/in_process_browser_test.h"
> #include "chrome/test/base/ui_test_utils.h"

Those three can be ignored for them, all the browser tests in content need to
include them until we finish content_browsertests. Until we have that, the
browser tests in content are actually now running in the chrome browsertests
target, and those files are needed to use it.

[jam, 2011-12-05 04:08:52]

+Avi for his thoughts on cocoa_test_helper.h

[Avi (use Gerrit), 2011-12-20 17:28:06]

On 2011/12/05 04:08:52, John Abd-El-Malek wrote:
> +Avi for his thoughts on cocoa_test_helper.h

Note that the guts of cocoa_test_helper were already moved out of chrome into
ui/base/test/ui_cocoa_test_helper.h. What remains is some packaging setup so
that resource lookup works, and I'm not the test expert. Does the test work if
you include the ui version?