Add OAuth2 revocation fetcher that is right now used for notifications.

Add OAuth2 revocation fetcher that is right now used for notifications.
Add unit tests.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113132

[Munjal (Google), 2011-12-06 00:44:58]

Rick/Zel/Tim, can one of you please review this?
Antony, you should probably also review.

[zel, 2011-12-06 01:18:19]

LGTM

http://codereview.chromium.org/8803029/diff/1/chrome/common/net/gaia/oauth2_r...
File chrome/common/net/gaia/oauth2_revocation_fetcher.cc (right):

http://codereview.chromium.org/8803029/diff/1/chrome/common/net/gaia/oauth2_r...
chrome/common/net/gaia/oauth2_revocation_fetcher.cc:118: if
(source->GetResponseCode() != RC_REQUEST_OK_EMPTY_BODY) {
what do you get here on regular 200 code?

[asargent_no_longer_on_chrome, 2011-12-06 01:33:59]

lgtm

[Munjal (Google), 2011-12-06 01:36:14]

Thanks for a quick review.

http://codereview.chromium.org/8803029/diff/1/chrome/common/net/gaia/oauth2_r...
File chrome/common/net/gaia/oauth2_revocation_fetcher.cc (right):

http://codereview.chromium.org/8803029/diff/1/chrome/common/net/gaia/oauth2_r...
chrome/common/net/gaia/oauth2_revocation_fetcher.cc:118: if
(source->GetResponseCode() != RC_REQUEST_OK_EMPTY_BODY) {
On 2011/12/06 01:18:19, zel wrote:
> what do you get here on regular 200 code?

We don't get a regular 200 code from this API. It returns 204: OK but no body.

[zel, 2011-12-06 01:53:11]

+mnissler FYI

[Mattias Nissler (ping if slow), 2011-12-06 09:04:02]

On 2011/12/06 01:53:11, zel wrote:
> +mnissler FYI

Hey guys, is this really different what I committed quite a while ago in
GaiaOAuthFetcher::StartOAuthRevokeAccessToken()? Given, this talks to a
different endpoint, but since the two quite similar, it may make sense to unify
the two or at least use the same pattern?