Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 8803023: Switch DownloadProtectionServiceTest to use pre-generated certs instead of creating them each time. (Closed)

Created:
9 years ago by Brian Ryner
Modified:
9 years ago
Reviewers:
noelutz, Ryan Sleevi, mattm
CC:
chromium-reviews, Paweł Hajdan Jr., Ryan Sleevi
Visibility:
Public.

Description

Switch DownloadProtectionServiceTest to use pre-generated certs instead of creating them each time. BUG=none TEST=DownloadProtectionServiceTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113297

Patch Set 1 #

Patch Set 2 : Fix an encoding problem #

Patch Set 3 : Fix leak #

Messages

Total messages: 6 (0 generated)
Brian Ryner
9 years ago (2011-12-06 04:36:16 UTC) #1
Ryan Sleevi
Thanks! LGTM
9 years ago (2011-12-06 04:41:47 UTC) #2
Brian Ryner
Noe or Matt, did you have any comments on this?
9 years ago (2011-12-06 21:47:48 UTC) #3
noelutz
lgtm
9 years ago (2011-12-06 22:40:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8803023/3001
9 years ago (2011-12-06 22:41:10 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 23:49:34 UTC) #6
Change committed as 113297

Powered by Google App Engine
This is Rietveld 408576698