Issue 8803013: Improve TraceIC logging

Issue 8803013: Improve TraceIC logging (Closed)

Created:
9 years ago by danno

Modified:
9 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve TraceIC logging Explicitly log generic stub transitions and the reason that they are happening. R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=10165

Patch Set 1 #

Patch Set 2 : Correct diff this time #

Patch Set 3 : make stuff actually compile #

Patch Set 4 : Fix release build #

Total comments: 7

Patch Set 5 : review feedback #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -32 lines)			Patch
M	src/frames.cc	View		2 chunks	+11 lines, -6 lines	0 comments	Download
M	src/ic.h	View	1 2 3 4	6 chunks	+20 lines, -6 lines	0 comments	Download
M	src/ic.cc	View	1 2 3 4	8 chunks	+23 lines, -18 lines	0 comments	Download
M	src/ic-inl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. http://codereview.chromium.org/8803013/diff/4001/src/flag-definitions.h File src/flag-definitions.h (left): http://codereview.chromium.org/8803013/diff/4001/src/flag-definitions.h#oldcode109 src/flag-definitions.h:109: DEFINE_bool(smi_only_arrays, true, "tracks arrays with only ...

9 years ago (2011-12-05 15:57:25 UTC) #2

danno

9 years ago (2011-12-06 14:26:00 UTC) #3

Feedback addressed and patch landed.

http://codereview.chromium.org/8803013/diff/4001/src/flag-definitions.h
File src/flag-definitions.h (left):

http://codereview.chromium.org/8803013/diff/4001/src/flag-definitions.h#oldco...
src/flag-definitions.h:109: DEFINE_bool(smi_only_arrays, true, "tracks arrays
with only smi values")
On 2011/12/05 15:57:26, Jakob wrote:
> This won't apply cleanly to bleeding_edge.

Done.

http://codereview.chromium.org/8803013/diff/4001/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/8803013/diff/4001/src/ic.cc#newcode85
src/ic.cc:85: IsGeneric() ? 'G' : TransitionMarkFromState(new_state));
On 2011/12/05 15:57:26, Jakob wrote:
> Would be nice to put the 'G' into TransitionMarkFromState, but you'd have to
> call it "TransitionMarkFromIC" then and pass in the entire IC instead of just
> its state... your call.

Done.

http://codereview.chromium.org/8803013/diff/4001/src/ic.cc#newcode94
src/ic.cc:94: PrintF("[KeyedLoadIC -> Installing generic stub in ");    \
On 2011/12/05 15:57:26, Jakob wrote:
> s/KeyedLoadIC/type/

Done.

Expand Messages | Collapse Messages