Issue 8803006: Implement Clipboard::ReadData and Clipboard::WriteData for Mac.

Issue 8803006: Implement Clipboard::ReadData and Clipboard::WriteData for Mac. (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
tony, sky

CC:
chromium-reviews, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement Clipboard::ReadData and Clipboard::WriteData for Mac. BUG=31037 TEST=ui_unittests --gtest_filter=ClipboardTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112986 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113018

Patch Set 4 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
M	ui/base/clipboard/clipboard.h	View	1 2 3	2 chunks	+1 line, -4 lines	0 comments	Download
M	ui/base/clipboard/clipboard.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/base/clipboard/clipboard_aurax11.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_mac.mm	View	1 2 3	4 chunks	+30 lines, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_unittest.cc	View	1 2	4 chunks	+1 line, -6 lines	0 comments	Download
M	ui/base/clipboard/clipboard_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dcheng

This is needed to support ScopedClipboardWriter::WritePickledData for http://codereview.chromium.org/8803005/ and http://crbug.com/31037.

9 years ago (2011-12-05 07:47:19 UTC) #1

tony

LGTM2 http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard.h File ui/base/clipboard/clipboard.h (right): http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard.h#newcode229 ui/base/clipboard/clipboard.h:229: // TODO(estade): port to mac. Nit: Get rid ...

9 years ago (2011-12-05 18:56:09 UTC) #3

dcheng

9 years ago (2011-12-05 19:53:03 UTC) #4

http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard.h
File ui/base/clipboard/clipboard.h (right):

http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard....
ui/base/clipboard/clipboard.h:229: // TODO(estade): port to mac.
On 2011/12/05 18:56:09, tony wrote:
> Nit: Get rid of the TODO.

Done.

http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_mac.mm (right):

http://codereview.chromium.org/8803006/diff/2003/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_mac.mm:371: result->assign(reinterpret_cast<const
char*>([data bytes]), [data length]);
On 2011/12/05 18:56:09, tony wrote:
> Nit: I think you can static_cast here.

Done.

Expand Messages | Collapse Messages