Issue 8803005: Helpers to pickle custom data for web copy/paste and drag/drop.

Issue 8803005: Helpers to pickle custom data for web copy/paste and drag/drop. (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
tony, sky

CC:
chromium-reviews, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Helpers to pickle custom data for web copy/paste and drag/drop. BUG=31037 TEST=ui_unittests --gtest_filter=CustomDataHelperTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113012

Patch Set 1 #

Patch Set 2 : Remove clunky StringPiece usage. #

Total comments: 4

Patch Set 3 : Review comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -0 lines)			Patch
A	ui/base/clipboard/custom_data_helper.h	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	ui/base/clipboard/custom_data_helper.cc	View	1 2	1 chunk	+131 lines, -0 lines	0 comments	Download
A	ui/base/clipboard/custom_data_helper_unittest.cc	View	1	1 chunk	+168 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/ui_unittests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/8803005/diff/2001/ui/base/clipboard/custom_data_helper.cc File ui/base/clipboard/custom_data_helper.cc (right): http://codereview.chromium.org/8803005/diff/2001/ui/base/clipboard/custom_data_helper.cc#newcode105 ui/base/clipboard/custom_data_helper.cc:105: string16 data; Nit: string16 data shadows the function ...

9 years ago (2011-12-05 18:20:15 UTC) #2

dcheng

9 years ago (2011-12-05 18:34:10 UTC) #4

http://codereview.chromium.org/8803005/diff/2001/ui/base/clipboard/custom_dat...
File ui/base/clipboard/custom_data_helper.cc (right):

http://codereview.chromium.org/8803005/diff/2001/ui/base/clipboard/custom_dat...
ui/base/clipboard/custom_data_helper.cc:105: string16 data;
On 2011/12/05 18:20:16, tony wrote:
> Nit: string16 data shadows the function arg data.  Maybe give it a different
> name to make it more clear.

Done. Not needed any more since we saved a copy below.

http://codereview.chromium.org/8803005/diff/2001/ui/base/clipboard/custom_dat...
ui/base/clipboard/custom_data_helper.cc:112: result->insert(std::make_pair(type,
data));
On 2011/12/05 18:20:16, tony wrote:
> Nit: I think we can save a copy of |data| by reading the type, then calling
> map::insert and passing the returned value into ReadString16.

Done.

Expand Messages | Collapse Messages