Issue 88025: * Add code to check coverage of generated code on IA32 port....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88025: * Add code to check coverage of generated code on IA32 port.... (Closed)

Created:
11 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Add code to check coverage of generated code on IA32 port. * Move ARM coverage code to ARM-specific file and add missing file to cover. Committed: http://code.google.com/p/v8/source/detail?r=1754

Patch Set 1 #

Total comments: 4

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -40 lines)			Patch
M	src/assembler-ia32.cc	View	3 chunks	+34 lines, -0 lines	2 comments	Download
M	src/builtins-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/codegen-ia32.cc	View	9 chunks	+15 lines, -11 lines	1 comment	Download
M	src/debug-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/ic-ia32.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/jump-target-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jump-target-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/macro-assembler-arm.h	View	1 chunk	+9 lines, -0 lines	1 comment	Download
M	src/macro-assembler-ia32.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/simulator-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/stub-cache-ia32.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/virtual-frame-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 8 months ago (2009-04-21 11:47:32 UTC) #1

Lgtm

http://codereview.chromium.org/88025/diff/1/12
File src/assembler-ia32.cc (right):

http://codereview.chromium.org/88025/diff/1/12#newcode2226
Line 2226: const char* return_address = (&file_line)[-1];
Maybe check or assert that coverage_log is set?

http://codereview.chromium.org/88025/diff/1/12#newcode2235
Line 2235: byte* ia32_coverage_function =
As discussed, there must be a way to make this nastiness go away.

http://codereview.chromium.org/88025/diff/1/13
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/88025/diff/1/13#newcode5281
Line 5281: int delta_to_patch_site =
masm_->SizeOfCodeGeneratedSince(patch_site());
Maybe a word somewhere about why you have to use masm_ instead of __.

http://codereview.chromium.org/88025/diff/1/2
File src/macro-assembler-arm.h (right):

http://codereview.chromium.org/88025/diff/1/2#newcode305
Line 305: #define DEFINE_MASM(masm) masm->stop(__FILE_LINE__); masm->
What is the significance of the name 'DEFINE_MASM'?  Sounds odd to me.

Expand Messages | Collapse Messages