Issue 8802024: Move web_contents_unittest.cc to content, where it belongs next to TabContents. Also rename it to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8802024: Move web_contents_unittest.cc to content, where it belongs next to TabContents. Also rename it to... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move web_contents_unittest.cc to content, where it belongs next to TabContents. Also rename it to tab_contents_unittests.cc. I've moved the one part that depended on PrefService to the pref service test. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113367

Patch Set 1 : '' #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -1836 lines)			Patch
M	chrome/browser/prefs/pref_service_unittest.cc	View		3 chunks	+63 lines, -0 lines	0 comments	Download
D	chrome/browser/tab_contents/web_contents_unittest.cc	View		1 chunk	+0 lines, -1777 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	content/browser/tab_contents/tab_contents_unittest.cc	View	1	10 chunks	+77 lines, -58 lines	0 comments	Download
M	content/content_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/8802024/13002

9 years ago (2011-12-06 21:47:23 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-06 21:47:25 UTC) #4

Can't apply patch for file
content/browser/tab_contents/tab_contents_unittest.cc.
While running patch -p0 --forward --force;
patching file content/browser/tab_contents/tab_contents_unittest.cc
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 166.
Hunk #4 FAILED at 212.
Hunk #5 FAILED at 407.
Hunk #6 FAILED at 468.
Hunk #7 FAILED at 592.
Hunk #8 FAILED at 722.
Hunk #9 FAILED at 739.
Hunk #10 FAILED at 899.
10 out of 10 hunks FAILED -- saving rejects to file
content/browser/tab_contents/tab_contents_unittest.cc.rej

Expand Messages | Collapse Messages