Issue 8802019: Roll libjingle to 98:99.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8802019: Roll libjingle to 98:99. (Closed)

Created:
9 years ago by tommi (sloooow) - chröme

Modified:
9 years ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, jam, dpranke-watch+content_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, joi+watch-content_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll libjingle to 98:99. - Refactoring and bug fixes - Remove global variables of class type. NOTE: I'm landing this for Ronghua since he's on leave. The change has already been reviewed here: http://codereview.chromium.org/8790011/ but I had to create a new issue in order to resolve merge conflicts. TBR=sergeyu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113086

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -7 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/p2p/ipc_network_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/fake_network_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/notifier_options_util.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/jingle_glue/xmpp_signal_strategy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/README.chromium	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/8802019/1

9 years ago (2011-12-05 20:39:52 UTC) #1

commit-bot: I haz the power

Try job failure for 8802019-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...

9 years ago (2011-12-05 21:03:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/8802019/1

9 years ago (2011-12-05 21:09:55 UTC) #3

Change committed as 113086

Expand Messages | Collapse Messages