Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 8802018: Add test where X is defined differentlty in co-importing libraries (Closed)

Created:
9 years ago by sra1
Modified:
9 years ago
Reviewers:
regis
CC:
reviews_dartlang.org, vsm, mmendez
Visibility:
Public.

Description

Add test where X is defined differentlty in co-importing libraries AFAIK this should work because the imports use prefixes. Frog: passes Dartc: passes VM: '/usr/local/google/home/sra/dart-all/dart/tests/language/src/LibrarySameNameUsedLib2.dart': Error: Class 'X' is used where an interface is expected Revert "Revert "Add test where X is defined differentlty in co-importing libraries"" This reverts commit d7f6a6c72e23d380f7af2af9958f77faa11787a7. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2095

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedLib1.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedLib2.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/src/LibrarySameNameUsedTest.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
This is the rollback of the rollback of r2083. It passed local tests but failed ...
9 years ago (2011-12-05 20:03:41 UTC) #1
sra1
9 years ago (2011-12-05 20:21:55 UTC) #2
sra1
Miguel - any idea why dartc thinks there is a #source here?
9 years ago (2011-12-05 20:23:53 UTC) #3
regis
9 years ago (2011-12-05 21:11:07 UTC) #4
LGTM

http://codereview.chromium.org/8802018/diff/1/tests/language/src/LibrarySameN...
File tests/language/src/LibrarySameNameUsedTest.dart (right):

http://codereview.chromium.org/8802018/diff/1/tests/language/src/LibrarySameN...
tests/language/src/LibrarySameNameUsedTest.dart:8:
#import("LibrarySameNameUsedLib1.dart");
I think that you need a #library clause before being able to use a #import
clause due to some limitation I am not familiar with.

Powered by Google App Engine
This is Rietveld 408576698