Enable custom MIME types in web copy/paste.

Enable custom MIME types in web copy/paste.

Also fixes a leak that was accidentally introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=113018.

BUG=31037, 106472
TEST=manual testing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113040

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113064

[dcheng, 2011-12-05 09:03:35]

This is the final follow up to http://codereview.chromium.org/8803005/ and
http://codereview.chromium.org/8803006/.

I've currently tested it fully on Mac, and I've tested that it builds on Linux.
I'll finish Windows testing tomorrow, but I don't expect any drastic changes.

[tony, 2011-12-05 18:40:39]

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_gtk.cc (right):

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_gtk.cc:110: const char kMimeTypeWebCustomData[] =
"chromium/x-web-custom-data";
We want this data to be interoperable with other browsers.  Putting chromium in
the name seems to work against that.  We should work with other browser vendors
and Hixie to get the actual type name speced.

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_mac.mm (right):

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_mac.mm:34: NSString* const kWebCustomDataType =
@"org.chromium.web-custom-data";
Ditto.

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/8802004/diff/1001/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_util_win.cc:207: static UINT cf =
RegisterClipboardFormat(L"Web Custom MIME Data Format");
Yeah, this seems better.

[dcheng, 2011-12-05 20:13:13]

As discussed, using the temporary names for now but I will get feedback from
whatwg and update them as appropriate.

I also added a small hack on Windows--if you look at
Clipboard::GetWebCustomDataFormatType(), it ends up returning the format name as
well. This is because all the callers of Clipboard::WritePickledData() make
assumptions that FormatType is actually a std::string, so WritePickledData()
ends up registering the format again on Windows. I plan on fixing that in a
followup CL by updating the bookmark code/tests and removing the hack.

[tony, 2011-12-05 20:24:50]

LGTM with the following fixed.

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_gtk.cc (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_gtk.cc:110: const char kMimeTypeWebCustomData[] =
"chromium/x-web-custom-data";
Please file a bug that this name is temporary and reference the bug number here
in a comment.

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_gtk.cc:397: DCHECK(clipboard);
Nit: Should we handle a NULL clipboard case in release?  Other callers seem to
handle it (and there's already a NOTREACHED() for the NULL case).

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_mac.mm (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_mac.mm:34: NSString* const kWebCustomDataType =
@"org.chromium.web-custom-data";
Same bug comment here (they can share a bug).

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_util_win.cc:208: RegisterClipboardFormat(L"Chromium
Web Custom MIME Data Format");
Same comment here.

[dcheng, 2011-12-05 20:51:03]

Sorry for the diff noise. I've been patching this CL in on different machines =(

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_gtk.cc (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_gtk.cc:110: const char kMimeTypeWebCustomData[] =
"chromium/x-web-custom-data";
On 2011/12/05 20:24:50, tony wrote:
> Please file a bug that this name is temporary and reference the bug number
here
> in a comment.

Done.

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_gtk.cc:397: DCHECK(clipboard);
On 2011/12/05 20:24:50, tony wrote:
> Nit: Should we handle a NULL clipboard case in release?  Other callers seem to
> handle it (and there's already a NOTREACHED() for the NULL case).

Done.

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_mac.mm (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_mac.mm:34: NSString* const kWebCustomDataType =
@"org.chromium.web-custom-data";
On 2011/12/05 20:24:50, tony wrote:
> Same bug comment here (they can share a bug).

Done.

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/8802004/diff/3004/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_util_win.cc:208: RegisterClipboardFormat(L"Chromium
Web Custom MIME Data Format");
On 2011/12/05 20:24:50, tony wrote:
> Same comment here.

Done.

[sky, 2011-12-05 21:58:00]

Since Tony reviewed, I'm rubber stamping this: LGTM