Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8802003: Implement Widget::NotifyLocaleChanged for Aura. (Closed)

Created:
9 years ago by Jun Mukai
Modified:
9 years ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement Widget::NotifyLocaleChanged for Aura. BUG=102574 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113750

Patch Set 1 #

Patch Set 2 : Fix silly mistakes #

Patch Set 3 : Use Desktop children instead of GetContainer() #

Patch Set 4 : Fix variable names #

Patch Set 5 : Remove unnecessary comment #

Total comments: 2

Patch Set 6 : Signal LocaleChanged() to all windows recursively #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
9 years ago (2011-12-06 16:40:17 UTC) #1
Emmanuel Saint-loubert-Bié
Lokks OK to me, but since there are several reviewers already I will remove myself, ...
9 years ago (2011-12-06 16:57:53 UTC) #2
Ben Goodger (Google)
http://codereview.chromium.org/8802003/diff/6001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8802003/diff/6001/ui/views/widget/native_widget_aura.cc#newcode692 ui/views/widget/native_widget_aura.cc:692: for (aura::Window::Windows::const_iterator container = top_containers.begin(); you're only notifying the ...
9 years ago (2011-12-06 17:02:47 UTC) #3
Jun Mukai
http://codereview.chromium.org/8802003/diff/6001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8802003/diff/6001/ui/views/widget/native_widget_aura.cc#newcode692 ui/views/widget/native_widget_aura.cc:692: for (aura::Window::Windows::const_iterator container = top_containers.begin(); On 2011/12/06 17:02:47, Ben ...
9 years ago (2011-12-08 02:00:11 UTC) #4
Ben Goodger (Google)
lgtm
9 years ago (2011-12-08 17:59:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/8802003/11001
9 years ago (2011-12-09 02:30:03 UTC) #6
commit-bot: I haz the power
Change committed as 113750
9 years ago (2011-12-09 03:43:16 UTC) #7
Nikita (slow)
9 years ago (2011-12-09 06:27:05 UTC) #8 
lgtm

Powered by Google App Engine
This is Rietveld 408576698