Issue 8802002: Rename ui::DefaultSymbolFromXEvent to ui::GetCharacterFromXEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8802002: Rename ui::DefaultSymbolFromXEvent to ui::GetCharacterFromXEvent. (Closed)

Created:
9 years ago by Yusuke Sato

Modified:
9 years ago

Reviewers:
James Su, sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename ui::DefaultSymbolFromXEvent to ui::GetCharacterFromXEvent following suzhe's suggestion. The new name would be more consistent since other functions that return a Unicode code point use ui::GetCharacterXXX. For example, keyboard_code_conversion.h has ui::GetCharacterFromKeyCode. BUG=None TEST=ran try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113586

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	content/browser/renderer_host/web_input_event_aurax11.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/event.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/mock_input_method.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/events/event_x.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8802002/7001

9 years ago (2011-12-08 09:27:34 UTC) #4

Change committed as 113586

Expand Messages | Collapse Messages