Allow Flash (and other plugins) to be installed without restarting the browse...

Allow Flash (and other plugins) to be installed without restarting the browser.  This works by monitoring the MozillaPlugins registry key and reloading the plugin list afterwards.

Note: I'll commit the WebKit change separately, but putting it in this change right now so everything can be reviewed together.

BUG=10574
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14377

[ananta, 2009-04-21 05:14:12]

Looks great overall.

http://codereview.chromium.org/88020/diff/1/7
File chrome/browser/plugin_service.cc (right):

http://codereview.chromium.org/88020/diff/1/7#newcode45
Line 45: HKEY_LOCAL_MACHINE, kRegistryMozillaPlugins, KEY_NOTIFY);
Should there be a DCHECK or a LOG if this fails?

http://codereview.chromium.org/88020/diff/1/9
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/88020/diff/1/9#newcode58
Line 58: void ResetChromiumPluginCache();
Should this be plugged through webkit glue?

http://codereview.chromium.org/88020/diff/1/9#newcode346
Line 346: WebCore::ResetChromiumPluginCache();
Ditto for whether this should be plugged through glue?

http://codereview.chromium.org/88020/diff/1/11
File third_party/WebKit/WebCore/plugins/chromium/PluginDataChromium.cpp (right):

http://codereview.chromium.org/88020/diff/1/11#newcode89
Line 89: pluginCache.reset(false);
Nit: 4 spaces

[jam, 2009-04-21 21:56:11]

http://codereview.chromium.org/88020/diff/1/7
File chrome/browser/plugin_service.cc (right):

http://codereview.chromium.org/88020/diff/1/7#newcode45
Line 45: HKEY_LOCAL_MACHINE, kRegistryMozillaPlugins, KEY_NOTIFY);
On 2009/04/21 05:14:12, ananta wrote:
> Should there be a DCHECK or a LOG if this fails?

I think this will be unlikely.  I guess the second create could fail for
non-admin users, but in that case a LOG doesn't make a difference..  I added an
if statement to only watch it if it succeeded.

http://codereview.chromium.org/88020/diff/1/9
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/88020/diff/1/9#newcode58
Line 58: void ResetChromiumPluginCache();
On 2009/04/21 05:14:12, ananta wrote:
> Should this be plugged through webkit glue?

I didn't see any advantage of doing that..

http://codereview.chromium.org/88020/diff/1/11
File third_party/WebKit/WebCore/plugins/chromium/PluginDataChromium.cpp (right):

http://codereview.chromium.org/88020/diff/1/11#newcode89
Line 89: pluginCache.reset(false);
On 2009/04/21 05:14:12, ananta wrote:
> Nit: 4 spaces
> 
> 

Done.

[ananta, 2009-04-21 22:58:54]

LGTM

[jam, 2009-04-23 20:03:26]

I've updated the patch slightly, in order to fix this not working on Youtube
(which was caused by the cache on WebCore::Page* objects, which remain the same
after a refresh).  The patch is now fully contained in Chromium code.

[ananta, 2009-04-23 20:57:15]

LGTM