Issue 8801034: Revert 112856 - Making profile avatars and names sync.

Issue 8801034: Revert 112856 - Making profile avatars and names sync. (Closed)

Created:
9 years ago by MAD

Modified:
8 years, 7 months ago

Reviewers:
sail, jwd

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 112856 - Making profile avatars and names sync. Broke some sync integration tests: http://crbug.com/106400 =========================================================== Initially fixing issue: BUG=87658 TEST=Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other. Review URL: http://codereview.chromium.org/8771024 TBR=jwd@chromium.org

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -195 lines)			Patch
M	chrome/browser/profiles/profile_impl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	4 chunks	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View	3 chunks	+10 lines, -56 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager_unittest.cc	View	10 chunks	+27 lines, -64 lines	0 comments	Download
M	chrome/browser/ui/webui/options/manage_profile_handler.cc	View	4 chunks	+4 lines, -16 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/8801034/1

9 years ago (2011-12-05 23:46:14 UTC) #2

MAD

Uploaded using drover for Jesse who couldn't do it because he doesn't have SVN write ...

9 years ago (2011-12-05 23:46:57 UTC) #3

sky

9 years ago (2011-12-06 05:53:55 UTC) #4

On 2011/12/05 23:46:57, MAD wrote:
> Uploaded using drover for Jesse who couldn't do it because he doesn't have SVN
> write access... We'll fix that...
> 
> Also, I hit the commit queue...
> 
> Enjoy!
> 
> BYE
> MAD

Sync tests on mac started failing, so I landed this and things seemed to be
behaving better.

  -Scott

Expand Messages | Collapse Messages