Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 8801030: Fixed update_manifest to correctly accept format: pepper -b .. -B ..... (Closed)

Created:
9 years ago by mball
Modified:
9 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fixed update_manifest to correctly accept format: pepper -b .. -B ..... BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -42 lines) Patch
M native_client_sdk/src/build_tools/sdk_tools/update_manifest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json View 1 chunk +93 lines, -41 lines 0 comments Download
A native_client_sdk/src/build_tools/tests/pepper_1_0/naclsdk_linux.tgz View 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/build_tools/tests/pepper_1_0/naclsdk_mac.tgz View 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/build_tools/tests/pepper_1_0/naclsdk_win.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/update_manifest_test.py View 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Ball
9 years ago (2011-12-05 23:11:32 UTC) #1
bradn
lgtm
9 years ago (2011-12-06 04:34:11 UTC) #2
Matt Ball
Doh! I'm running into that OWNERS issue again... Brad -- Would you mind approving again ...
9 years ago (2011-12-06 14:13:57 UTC) #3
noelallen1
LGTM
9 years ago (2011-12-06 18:05:42 UTC) #4
bradnelson
9 years ago (2011-12-06 18:46:50 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698