Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 8801012: Add support for content::Referrer to prerender (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
cbentzel, jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

Add support for content::Referrer to prerender BUG=105028 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113070

Patch Set 1 #

Total comments: 6

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -38 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 7 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_unittest.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
Chris, please review John: content/ approval
9 years ago (2011-12-05 16:53:45 UTC) #1
jam
content lgtm
9 years ago (2011-12-05 17:45:09 UTC) #2
cbentzel
http://codereview.chromium.org/8801012/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/8801012/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode205 chrome/browser/prerender/prerender_browsertest.cc:205: const content::Referrer& referrer) { Should have OVERRIDE - I ...
9 years ago (2011-12-05 18:03:29 UTC) #3
jochen (gone - plz use gerrit)
http://codereview.chromium.org/8801012/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/8801012/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode205 chrome/browser/prerender/prerender_browsertest.cc:205: const content::Referrer& referrer) { On 2011/12/05 18:03:29, cbentzel wrote: ...
9 years ago (2011-12-05 20:46:34 UTC) #4
cbentzel
LGTM
9 years ago (2011-12-05 21:09:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8801012/2002
9 years ago (2011-12-05 21:58:01 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-06 00:17:53 UTC) #7
Change committed as 113070

Powered by Google App Engine
This is Rietveld 408576698