Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 8801008: Enable RenderViewImplTest.{OnHandleKeyboardEvent,InsertCharacters} for Aura on X11. (Closed)

Created:
9 years ago by mazda
Modified:
9 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Enable RenderViewImplTest.{OnHandleKeyboardEvent,InsertCharacters} for Aura on X11. BUG=103499 TEST=Ran RenderViewImplTest.{OnHandleKeyboardEvent,InsertCharacter}.

Patch Set 1 #

Patch Set 2 : Fix build break #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -25 lines) Patch
M content/renderer/render_view_browsertest.cc View 4 chunks +4 lines, -18 lines 0 comments Download
M content/test/render_view_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/render_view_test.cc View 1 5 chunks +148 lines, -6 lines 0 comments Download
M ui/base/keycodes/keyboard_code_conversion_x.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mazda
Can I ask you to review this CL?
9 years ago (2011-12-06 04:28:23 UTC) #1
Daniel Erat
lgtm
9 years ago (2011-12-06 05:27:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8801008/2001
9 years ago (2011-12-06 05:36:49 UTC) #3
commit-bot: I haz the power
Presubmit check for 8801008-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-06 05:36:51 UTC) #4
mazda
Ben, Could you approve this CL if it looks good?
9 years ago (2011-12-06 05:46:13 UTC) #5
Ben Goodger (Google)
LGTM for ui
9 years ago (2011-12-06 16:29:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8801008/2001
9 years ago (2011-12-07 01:12:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8801008/2001
9 years ago (2011-12-07 02:52:49 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-07 02:52:51 UTC) #9
Can't apply patch for file content/renderer/render_view_browsertest.cc.
While running patch -p1 --forward --force;
patching file content/renderer/render_view_browsertest.cc
Hunk #1 FAILED at 521.
Hunk #2 FAILED at 638.
Hunk #3 FAILED at 674.
Hunk #4 FAILED at 886.
4 out of 4 hunks FAILED -- saving rejects to file
content/renderer/render_view_browsertest.cc.rej

Powered by Google App Engine
This is Rietveld 408576698