Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/socket/transport_client_socket_pool_unittest.cc

Issue 8801005: base::Bind: Convert Socket::Read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | net/socket/web_socket_server_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/transport_client_socket_pool_unittest.cc
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index 66047275ab4c4f85a87fb9e9030c9ac769e9df6e..56b1fa9c9554701757017487f09fa9546bf0f21c 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -94,11 +94,15 @@ class MockClientSocket : public StreamSocket {
return base::TimeDelta::FromMicroseconds(-1);
}
- // Socket methods:
+ // Socket implementation.
virtual int Read(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
return ERR_FAILED;
}
+ virtual int Read(IOBuffer* buf, int buf_len,
+ const CompletionCallback& callback) {
+ return ERR_FAILED;
+ }
virtual int Write(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
return ERR_FAILED;
@@ -151,11 +155,15 @@ class MockFailingClientSocket : public StreamSocket {
return base::TimeDelta::FromMicroseconds(-1);
}
- // Socket methods:
+ // Socket implementation.
virtual int Read(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
return ERR_FAILED;
}
+ virtual int Read(IOBuffer* buf, int buf_len,
+ const CompletionCallback& callback) {
+ return ERR_FAILED;
+ }
virtual int Write(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
@@ -238,11 +246,15 @@ class MockPendingClientSocket : public StreamSocket {
return base::TimeDelta::FromMicroseconds(-1);
}
- // Socket methods:
+ // Socket implementation.
virtual int Read(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
return ERR_FAILED;
}
+ virtual int Read(IOBuffer* buf, int buf_len,
+ const CompletionCallback& callback) {
+ return ERR_FAILED;
+ }
virtual int Write(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | net/socket/web_socket_server_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698