Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 8801005: base::Bind: Convert Socket::Read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.h ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index e6e9aac2357a6d6984444d8bcf4b5b28ef426816..12373488f909af5960292cfc2973a70e07a2679d 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -391,7 +391,7 @@ SSLClientSocketOpenSSL::SSLClientSocketOpenSSL(
transport_send_busy_(false),
transport_recv_busy_(false),
old_user_connect_callback_(NULL),
- user_read_callback_(NULL),
+ old_user_read_callback_(NULL),
user_write_callback_(NULL),
completed_handshake_(false),
client_auth_cert_needed_(false),
@@ -614,11 +614,19 @@ SSLClientSocket::NextProtoStatus SSLClientSocketOpenSSL::GetNextProto(
void SSLClientSocketOpenSSL::DoReadCallback(int rv) {
// Since Run may result in Read being called, clear |user_read_callback_|
// up front.
- OldCompletionCallback* c = user_read_callback_;
- user_read_callback_ = NULL;
- user_read_buf_ = NULL;
- user_read_buf_len_ = 0;
- c->Run(rv);
+ if (old_user_read_callback_) {
+ OldCompletionCallback* c = old_user_read_callback_;
+ old_user_read_callback_ = NULL;
+ user_read_buf_ = NULL;
+ user_read_buf_len_ = 0;
+ c->Run(rv);
+ } else {
+ CompletionCallback c = user_read_callback_;
+ user_read_callback_.Reset();
+ user_read_buf_ = NULL;
+ user_read_buf_len_ = 0;
+ c.Run(rv);
+ }
}
void SSLClientSocketOpenSSL::DoWriteCallback(int rv) {
@@ -702,7 +710,8 @@ void SSLClientSocketOpenSSL::Disconnect() {
old_user_connect_callback_ = NULL;
user_connect_callback_.Reset();
- user_read_callback_ = NULL;
+ old_user_read_callback_ = NULL;
+ user_read_callback_.Reset();
user_write_callback_ = NULL;
user_read_buf_ = NULL;
user_read_buf_len_ = 0;
@@ -1188,6 +1197,23 @@ int SSLClientSocketOpenSSL::Read(IOBuffer* buf,
int rv = DoReadLoop(OK);
if (rv == ERR_IO_PENDING) {
+ old_user_read_callback_ = callback;
+ } else {
+ user_read_buf_ = NULL;
+ user_read_buf_len_ = 0;
+ }
+
+ return rv;
+}
+int SSLClientSocketOpenSSL::Read(IOBuffer* buf,
+ int buf_len,
+ const CompletionCallback& callback) {
+ user_read_buf_ = buf;
+ user_read_buf_len_ = buf_len;
+
+ int rv = DoReadLoop(OK);
+
+ if (rv == ERR_IO_PENDING) {
user_read_callback_ = callback;
} else {
user_read_buf_ = NULL;
« no previous file with comments | « net/socket/ssl_client_socket_openssl.h ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698