Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 8801005: base::Bind: Convert Socket::Read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base_unittest.cc
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index d318dd6fab48fc6e05dbde9468f492d9e8f253c3..fdbc63f139f0aaf39f14cc9b92317d65d2d2d053 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -49,12 +49,17 @@ class MockClientSocket : public StreamSocket {
MockClientSocket() : connected_(false), was_used_to_convey_data_(false),
num_bytes_read_(0) {}
- // Socket methods:
+ // Socket implementation.
virtual int Read(
IOBuffer* /* buf */, int len, OldCompletionCallback* /* callback */) {
num_bytes_read_ += len;
return len;
}
+ virtual int Read(
+ IOBuffer* /* buf */, int len, const CompletionCallback& /* callback */) {
+ num_bytes_read_ += len;
+ return len;
+ }
virtual int Write(
IOBuffer* /* buf */, int len, OldCompletionCallback* /* callback */) {
@@ -211,7 +216,7 @@ class TestConnectJob : public ConnectJob {
}
private:
- // ConnectJob methods:
+ // ConnectJob implementation.
virtual int ConnectInternal() {
AddressList ignored;
@@ -366,8 +371,7 @@ class TestConnectJobFactory
timeout_duration_ = timeout_duration;
}
- // ConnectJobFactory methods:
-
+ // ConnectJobFactory implementation.
virtual ConnectJob* NewConnectJob(
const std::string& group_name,
const TestClientSocketPoolBase::Request& request,

Powered by Google App Engine
This is Rietveld 408576698