Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: remoting/protocol/pepper_transport_socket_adapter.cc

Issue 8801005: base::Bind: Convert Socket::Read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/protocol/pepper_transport_socket_adapter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/protocol/pepper_transport_socket_adapter.h" 5 #include "remoting/protocol/pepper_transport_socket_adapter.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/base/address_list.h" 8 #include "net/base/address_list.h"
9 #include "net/base/io_buffer.h" 9 #include "net/base/io_buffer.h"
10 #include "net/base/net_errors.h" 10 #include "net/base/net_errors.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 PepperTransportSocketAdapter::PepperTransportSocketAdapter( 43 PepperTransportSocketAdapter::PepperTransportSocketAdapter(
44 pp::Transport_Dev* transport, 44 pp::Transport_Dev* transport,
45 const std::string& name, 45 const std::string& name,
46 Observer* observer) 46 Observer* observer)
47 : name_(name), 47 : name_(name),
48 observer_(observer), 48 observer_(observer),
49 transport_(transport), 49 transport_(transport),
50 connected_(false), 50 connected_(false),
51 get_address_pending_(false), 51 get_address_pending_(false),
52 read_callback_(NULL), 52 old_read_callback_(NULL),
53 write_callback_(NULL) { 53 write_callback_(NULL) {
54 callback_factory_.Initialize(this); 54 callback_factory_.Initialize(this);
55 } 55 }
56 56
57 PepperTransportSocketAdapter::~PepperTransportSocketAdapter() { 57 PepperTransportSocketAdapter::~PepperTransportSocketAdapter() {
58 observer_->OnChannelDeleted(); 58 observer_->OnChannelDeleted();
59 } 59 }
60 60
61 void PepperTransportSocketAdapter::AddRemoteCandidate( 61 void PepperTransportSocketAdapter::AddRemoteCandidate(
62 const std::string& candidate) { 62 const std::string& candidate) {
63 DCHECK(CalledOnValidThread()); 63 DCHECK(CalledOnValidThread());
64 if (transport_.get()) 64 if (transport_.get())
65 transport_->ReceiveRemoteAddress(candidate); 65 transport_->ReceiveRemoteAddress(candidate);
66 } 66 }
67 67
68 int PepperTransportSocketAdapter::Read(net::IOBuffer* buf, int buf_len, 68 int PepperTransportSocketAdapter::Read(net::IOBuffer* buf, int buf_len,
69 net::OldCompletionCallback* callback) { 69 net::OldCompletionCallback* callback) {
70 DCHECK(CalledOnValidThread()); 70 DCHECK(CalledOnValidThread());
71 DCHECK(!read_callback_); 71 DCHECK(!old_read_callback_ && read_callback_.is_null());
72 DCHECK(!read_buffer_); 72 DCHECK(!read_buffer_);
73 73
74 if (!transport_.get()) 74 if (!transport_.get())
75 return net::ERR_SOCKET_NOT_CONNECTED;
76
77 int result = PPErrorToNetError(transport_->Recv(
78 buf->data(), buf_len,
79 callback_factory_.NewOptionalCallback(
80 &PepperTransportSocketAdapter::OnRead)));
81
82 if (result == net::ERR_IO_PENDING) {
83 old_read_callback_ = callback;
84 read_buffer_ = buf;
85 }
86
87 return result;
88 }
89 int PepperTransportSocketAdapter::Read(
90 net::IOBuffer* buf, int buf_len,
91 const net::CompletionCallback& callback) {
92 DCHECK(CalledOnValidThread());
93 DCHECK(!old_read_callback_ && read_callback_.is_null());
94 DCHECK(!read_buffer_);
95
96 if (!transport_.get())
75 return net::ERR_SOCKET_NOT_CONNECTED; 97 return net::ERR_SOCKET_NOT_CONNECTED;
76 98
77 int result = PPErrorToNetError(transport_->Recv( 99 int result = PPErrorToNetError(transport_->Recv(
78 buf->data(), buf_len, 100 buf->data(), buf_len,
79 callback_factory_.NewOptionalCallback( 101 callback_factory_.NewOptionalCallback(
80 &PepperTransportSocketAdapter::OnRead))); 102 &PepperTransportSocketAdapter::OnRead)));
81 103
82 if (result == net::ERR_IO_PENDING) { 104 if (result == net::ERR_IO_PENDING) {
83 read_callback_ = callback; 105 read_callback_ = callback;
84 read_buffer_ = buf; 106 read_buffer_ = buf;
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 callback->Run(PPErrorToNetError(result)); 311 callback->Run(PPErrorToNetError(result));
290 } else { 312 } else {
291 net::CompletionCallback callback = connect_callback_; 313 net::CompletionCallback callback = connect_callback_;
292 connect_callback_.Reset(); 314 connect_callback_.Reset();
293 callback.Run(PPErrorToNetError(result)); 315 callback.Run(PPErrorToNetError(result));
294 } 316 }
295 } 317 }
296 318
297 void PepperTransportSocketAdapter::OnRead(int32_t result) { 319 void PepperTransportSocketAdapter::OnRead(int32_t result) {
298 DCHECK(CalledOnValidThread()); 320 DCHECK(CalledOnValidThread());
299 DCHECK(read_callback_); 321 DCHECK(old_read_callback_ || read_callback_.is_null());
300 DCHECK(read_buffer_); 322 DCHECK(read_buffer_);
301 323
302 net::OldCompletionCallback* callback = read_callback_; 324 if (old_read_callback_) {
303 read_callback_ = NULL; 325 net::OldCompletionCallback* callback = old_read_callback_;
304 read_buffer_ = NULL; 326 old_read_callback_ = NULL;
305 callback->Run(PPErrorToNetError(result)); 327 read_buffer_ = NULL;
328 callback->Run(PPErrorToNetError(result));
329 } else {
330 net::CompletionCallback callback = read_callback_;
331 read_callback_.Reset();
332 read_buffer_ = NULL;
333 callback.Run(PPErrorToNetError(result));
334 }
306 } 335 }
307 336
308 void PepperTransportSocketAdapter::OnWrite(int32_t result) { 337 void PepperTransportSocketAdapter::OnWrite(int32_t result) {
309 DCHECK(CalledOnValidThread()); 338 DCHECK(CalledOnValidThread());
310 DCHECK(write_callback_); 339 DCHECK(write_callback_);
311 DCHECK(write_buffer_); 340 DCHECK(write_buffer_);
312 341
313 net::OldCompletionCallback* callback = write_callback_; 342 net::OldCompletionCallback* callback = write_callback_;
314 write_callback_ = NULL; 343 write_callback_ = NULL;
315 write_buffer_ = NULL; 344 write_buffer_ = NULL;
316 callback->Run(PPErrorToNetError(result)); 345 callback->Run(PPErrorToNetError(result));
317 } 346 }
318 347
319 } // namespace protocol 348 } // namespace protocol
320 } // namespace remoting 349 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/protocol/pepper_transport_socket_adapter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698