Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: remoting/protocol/pepper_transport_socket_adapter.cc

Issue 8801004: base::Bind: Convert StreamSocket::Connect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/pepper_transport_socket_adapter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/pepper_transport_socket_adapter.cc
diff --git a/remoting/protocol/pepper_transport_socket_adapter.cc b/remoting/protocol/pepper_transport_socket_adapter.cc
index 6acb8e3007b0b33811b1a43d24e2ed5a17a2988f..a48afce329b690f9dee88fa296609622d2f1b3d0 100644
--- a/remoting/protocol/pepper_transport_socket_adapter.cc
+++ b/remoting/protocol/pepper_transport_socket_adapter.cc
@@ -123,7 +123,31 @@ bool PepperTransportSocketAdapter::SetSendBufferSize(int32 size) {
return false;
}
-int PepperTransportSocketAdapter::Connect(net::OldCompletionCallback* callback) {
+int PepperTransportSocketAdapter::Connect(
+ net::OldCompletionCallback* callback) {
+ DCHECK(CalledOnValidThread());
+
+ if (!transport_.get())
+ return net::ERR_UNEXPECTED;
+
+ old_connect_callback_ = callback;
+
+ // This will return false when GetNextAddress() returns an
+ // error. This helps to detect when the P2P Transport API is not
+ // supported.
+ int result = ProcessCandidates();
+ if (result != net::OK)
+ return result;
+
+ result = transport_->Connect(
+ callback_factory_.NewRequiredCallback(
+ &PepperTransportSocketAdapter::OnConnect));
+ DCHECK_EQ(result, PP_OK_COMPLETIONPENDING);
+
+ return net::ERR_IO_PENDING;
+}
+int PepperTransportSocketAdapter::Connect(
+ const net::CompletionCallback& callback) {
DCHECK(CalledOnValidThread());
if (!transport_.get())
@@ -254,14 +278,20 @@ void PepperTransportSocketAdapter::OnNextAddress(int32_t result) {
void PepperTransportSocketAdapter::OnConnect(int result) {
DCHECK(CalledOnValidThread());
- DCHECK(connect_callback_);
+ DCHECK(old_connect_callback_ || !connect_callback_.is_null());
if (result == PP_OK)
connected_ = true;
- net::OldCompletionCallback* callback = connect_callback_;
- connect_callback_ = NULL;
- callback->Run(PPErrorToNetError(result));
+ if (old_connect_callback_) {
+ net::OldCompletionCallback* callback = old_connect_callback_;
+ old_connect_callback_ = NULL;
+ callback->Run(PPErrorToNetError(result));
+ } else {
+ net::CompletionCallback callback = connect_callback_;
+ connect_callback_.Reset();
+ callback.Run(PPErrorToNetError(result));
+ }
}
void PepperTransportSocketAdapter::OnRead(int32_t result) {
« no previous file with comments | « remoting/protocol/pepper_transport_socket_adapter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698