| Index: net/socket/socket_test_util.h
|
| diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
|
| index e1d2b2a48f28e5167aa6219df2b777a674b1a149..b7c7df26f548e16571cf215e7f699459e2a473db 100644
|
| --- a/net/socket/socket_test_util.h
|
| +++ b/net/socket/socket_test_util.h
|
| @@ -198,7 +198,7 @@ class StaticSocketDataProvider : public SocketDataProvider {
|
|
|
| virtual void CompleteRead() {}
|
|
|
| - // SocketDataProvider methods:
|
| + // SocketDataProvider implementation.
|
| virtual MockRead GetNextRead() OVERRIDE;
|
| virtual MockWriteResult OnWrite(const std::string& data) OVERRIDE;
|
| virtual void Reset() OVERRIDE;
|
| @@ -228,7 +228,7 @@ class DynamicSocketDataProvider : public SocketDataProvider {
|
|
|
| void allow_unconsumed_reads(bool allow) { allow_unconsumed_reads_ = allow; }
|
|
|
| - // SocketDataProvider methods:
|
| + // SocketDataProvider implementation.
|
| virtual MockRead GetNextRead() OVERRIDE;
|
| virtual MockWriteResult OnWrite(const std::string& data) = 0;
|
| virtual void Reset() OVERRIDE;
|
| @@ -583,7 +583,7 @@ class MockClientSocket : public net::SSLClientSocket {
|
| public:
|
| explicit MockClientSocket(net::NetLog* net_log);
|
|
|
| - // Socket methods:
|
| + // Socket implementation.
|
| virtual int Read(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) = 0;
|
| virtual int Write(net::IOBuffer* buf, int buf_len,
|
| @@ -591,8 +591,9 @@ class MockClientSocket : public net::SSLClientSocket {
|
| virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;
|
| virtual bool SetSendBufferSize(int32 size) OVERRIDE;
|
|
|
| - // StreamSocket methods:
|
| + // StreamSocket implementation.
|
| virtual int Connect(net::OldCompletionCallback* callback) = 0;
|
| + virtual int Connect(const net::CompletionCallback& callback) = 0;
|
| virtual void Disconnect() OVERRIDE;
|
| virtual bool IsConnected() const OVERRIDE;
|
| virtual bool IsConnectedAndIdle() const OVERRIDE;
|
| @@ -602,7 +603,7 @@ class MockClientSocket : public net::SSLClientSocket {
|
| virtual void SetSubresourceSpeculation() OVERRIDE {}
|
| virtual void SetOmniboxSpeculation() OVERRIDE {}
|
|
|
| - // SSLClientSocket methods:
|
| + // SSLClientSocket implementation.
|
| virtual void GetSSLInfo(net::SSLInfo* ssl_info) OVERRIDE;
|
| virtual void GetSSLCertRequestInfo(
|
| net::SSLCertRequestInfo* cert_request_info) OVERRIDE;
|
| @@ -615,9 +616,11 @@ class MockClientSocket : public net::SSLClientSocket {
|
| protected:
|
| virtual ~MockClientSocket();
|
| void RunCallbackAsync(net::OldCompletionCallback* callback, int result);
|
| - void RunCallback(net::OldCompletionCallback*, int result);
|
| + void RunCallbackAsync(const net::CompletionCallback& callback, int result);
|
| + void RunOldCallback(net::OldCompletionCallback*, int result);
|
| + void RunCallback(const net::CompletionCallback&, int result);
|
|
|
| - ScopedRunnableMethodFactory<MockClientSocket> method_factory_;
|
| + base::WeakPtrFactory<MockClientSocket> weak_factory_;
|
|
|
| // True if Connect completed successfully and Disconnect hasn't been called.
|
| bool connected_;
|
| @@ -632,14 +635,15 @@ class MockTCPClientSocket : public MockClientSocket, public AsyncSocket {
|
|
|
| net::AddressList addresses() const { return addresses_; }
|
|
|
| - // Socket methods:
|
| + // Socket implementation.
|
| virtual int Read(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) OVERRIDE;
|
| virtual int Write(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) OVERRIDE;
|
|
|
| - // StreamSocket methods:
|
| + // StreamSocket implementation.
|
| virtual int Connect(net::OldCompletionCallback* callback) OVERRIDE;
|
| + virtual int Connect(const net::CompletionCallback& callback) OVERRIDE;
|
| virtual void Disconnect() OVERRIDE;
|
| virtual bool IsConnected() const OVERRIDE;
|
| virtual bool IsConnectedAndIdle() const OVERRIDE;
|
| @@ -695,8 +699,9 @@ class DeterministicMockTCPClientSocket : public MockClientSocket,
|
| virtual int Read(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) OVERRIDE;
|
|
|
| - // StreamSocket:
|
| + // StreamSocket implementation.
|
| virtual int Connect(net::OldCompletionCallback* callback) OVERRIDE;
|
| + virtual int Connect(const net::CompletionCallback& callback) OVERRIDE;
|
| virtual void Disconnect() OVERRIDE;
|
| virtual bool IsConnected() const OVERRIDE;
|
| virtual bool IsConnectedAndIdle() const OVERRIDE;
|
| @@ -733,14 +738,15 @@ class MockSSLClientSocket : public MockClientSocket, public AsyncSocket {
|
| net::SSLSocketDataProvider* socket);
|
| virtual ~MockSSLClientSocket();
|
|
|
| - // Socket methods:
|
| + // Socket implementation.
|
| virtual int Read(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) OVERRIDE;
|
| virtual int Write(net::IOBuffer* buf, int buf_len,
|
| net::OldCompletionCallback* callback) OVERRIDE;
|
|
|
| - // StreamSocket methods:
|
| + // StreamSocket implementation.
|
| virtual int Connect(net::OldCompletionCallback* callback) OVERRIDE;
|
| + virtual int Connect(const net::CompletionCallback& callback) OVERRIDE;
|
| virtual void Disconnect() OVERRIDE;
|
| virtual bool IsConnected() const OVERRIDE;
|
| virtual bool WasEverUsed() const OVERRIDE;
|
| @@ -748,7 +754,7 @@ class MockSSLClientSocket : public MockClientSocket, public AsyncSocket {
|
| virtual int64 NumBytesRead() const OVERRIDE;
|
| virtual base::TimeDelta GetConnectTimeMicros() const OVERRIDE;
|
|
|
| - // SSLClientSocket methods:
|
| + // SSLClientSocket implementation.
|
| virtual void GetSSLInfo(net::SSLInfo* ssl_info) OVERRIDE;
|
| virtual void GetSSLCertRequestInfo(
|
| net::SSLCertRequestInfo* cert_request_info) OVERRIDE;
|
| @@ -760,6 +766,7 @@ class MockSSLClientSocket : public MockClientSocket, public AsyncSocket {
|
| virtual void OnReadComplete(const MockRead& data) OVERRIDE;
|
|
|
| private:
|
| + class OldConnectCallback;
|
| class ConnectCallback;
|
|
|
| scoped_ptr<ClientSocketHandle> transport_;
|
| @@ -814,7 +821,7 @@ class MockUDPClientSocket : public DatagramClientSocket,
|
|
|
| BoundNetLog net_log_;
|
|
|
| - ScopedRunnableMethodFactory<MockUDPClientSocket> method_factory_;
|
| + base::WeakPtrFactory<MockUDPClientSocket> weak_factory_;
|
|
|
| DISALLOW_COPY_AND_ASSIGN(MockUDPClientSocket);
|
| };
|
|
|