chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc - Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 8801003: Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Also get rid of content usage and remove the method Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | chrome/browser/tab_contents/web_contents_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

===================================================================

--- chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc (revision 112951)

+++ chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc (working copy)

@@ -22,12 +22,13 @@

#include "chrome/test/base/testing_profile.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/browser/tab_contents/test_tab_contents.h"

-#include "content/common/view_messages.h"

#include "content/public/common/page_transition_types.h"

+#include "content/public/common/referrer.h"

#include "content/test/test_browser_thread.h"

#include "googleurl/src/gurl.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "third_party/WebKit/Source/WebKit/chromium/public/WebReferrerPolicy.h"

using ::testing::Return;

using ::testing::StrictMock;

@@ -95,17 +96,14 @@

contents()->controller().LoadURL(url, referrer, type, std::string());

static int page_id = 0;

- ViewHostMsg_FrameNavigate_Params params;

- InitNavigateParams(&params, ++page_id, url, type);

- params.referrer =

- content::Referrer(referrer, WebKit::WebReferrerPolicyDefault);

RenderViewHost* rvh = contents()->pending_rvh();

if (!rvh) {

rvh = contents()->render_view_host();

}

contents()->ProceedWithCrossSiteNavigation();

- contents()->TestDidNavigate(rvh, params);

+ contents()->TestDidNavigateWithReferrer(

+ rvh, ++page_id, url,

+ content::Referrer(referrer, WebKit::WebReferrerPolicyDefault), type);

}

bool ExtractFeatures(ClientPhishingRequest* request) {