Issue 8801001: Get rid of view_messages.h dependency in extension_messages_browsertest.cc by adding a method to ...

Issue 8801001: Get rid of view_messages.h dependency in extension_messages_browsertest.cc by adding a method to ... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
tfarina

CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., ajwong+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of view_messages.h dependency in extension_messages_browsertest.cc by adding a method to MockRenderThread instead. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112987

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -26 lines)			Patch
M	chrome/browser/extensions/extension_messages_browsertest.cc	View		3 chunks	+5 lines, -24 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/chrome_render_view_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/test/mock_render_thread.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/test/mock_render_thread.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

On 2011/12/05 01:05:31, John Abd-El-Malek wrote: It looks right to me. I trust in you. ...

9 years ago (2011-12-05 01:17:34 UTC) #2

tfarina

http://codereview.chromium.org/8801001/diff/1/content/test/mock_render_thread.h File content/test/mock_render_thread.h (right): http://codereview.chromium.org/8801001/diff/1/content/test/mock_render_thread.h#newcode34 content/test/mock_render_thread.h:34: void VerifyRunJavaScriptMessageSend(const string16& expected_alert_message); can we include string16.h for ...

9 years ago (2011-12-05 01:17:42 UTC) #3

jam

9 years ago (2011-12-05 03:20:41 UTC) #4

http://codereview.chromium.org/8801001/diff/1/content/test/mock_render_thread.h
File content/test/mock_render_thread.h (right):

http://codereview.chromium.org/8801001/diff/1/content/test/mock_render_thread...
content/test/mock_render_thread.h:34: void VerifyRunJavaScriptMessageSend(const
string16& expected_alert_message);
On 2011/12/05 01:17:43, tfarina wrote:
> can we include string16.h for it?

Done.

Expand Messages | Collapse Messages