Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 8800034: Use nacl_helper_bootstrap from native_client repository (Closed)

Created:
9 years ago by Roland McGrath
Modified:
6 years, 6 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, pam+watch_chromium.org
Visibility:
Public.

Description

Use nacl_helper_bootstrap from native_client repository These sources have been moved over to the native_client repository. Remove them from chromium/src altogether and just make the gyp files refer to the native_client stuff. BUG= none TEST= linux still builds R=sehr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113133

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1025 lines) Patch
M DEPS View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl.gypi View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/nacl/nacl_helper_bootstrap_linux.c View 1 chunk +0 lines, -575 lines 0 comments Download
D chrome/nacl/nacl_helper_bootstrap_linux.x View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/nacl/nacl_helper_bootstrap_munge_phdr.c View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/nacl/nacl_helper_bootstrap_munge_phdr.py View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/ld_bfd/ld View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
This is to re-land http://codereview.chromium.org/8805032/ after http://codereview.chromium.org/8805032/ (nacl DEPS roll) lands. After the DEPS change ...
9 years ago (2011-12-06 01:16:24 UTC) #1
sehr (please use chromium)
On 2011/12/06 01:16:24, Roland McGrath wrote: > This is to re-land http://codereview.chromium.org/8805032/ after > http://codereview.chromium.org/8805032/ ...
9 years ago (2011-12-06 01:18:37 UTC) #2
Nico
6 years, 6 months ago (2014-06-17 18:01:45 UTC) #3
Message was sent while issue was closed.
(It would've saved me 10 minutes of digging through logs this morning if you had
used a tracking bug for moving nacl_helper_bootstrap and referenced it both here
and in the nacl cl.)

Powered by Google App Engine
This is Rietveld 408576698