Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4005)

Unified Diff: chrome/browser/ui/views/window.cc

Issue 8800032: Make BubbleWindow a Widget override with a BubbleFrameView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/window.cc
diff --git a/chrome/browser/ui/views/window.cc b/chrome/browser/ui/views/window.cc
index 49e6cc729456646759015d2513c4bb89082906a0..3827a1df28b3f73cd53ca4f24ef7e8d7593a10c9 100644
--- a/chrome/browser/ui/views/window.cc
+++ b/chrome/browser/ui/views/window.cc
@@ -7,20 +7,22 @@
#include "ui/views/bubble/bubble_delegate.h"
#include "ui/views/widget/widget.h"
-#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
+#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/frame/bubble_window.h"
+
+#if defined(TOOLKIT_USES_GTK)
#include "chrome/browser/chromeos/legacy_window_manager/wm_ipc.h"
#include "third_party/cros_system_api/window_manager/chromeos_wm_ipc_enums.h"
-#endif
+#endif // TOOLKIT_USES_GTK
+
+#endif // OS_CHROMEOS
James Cook 2011/12/06 04:48:34 Thanks for commenting the #endif's -- I find this
msw 2011/12/06 06:05:14 :)
namespace browser {
views::Widget* CreateViewsWindow(gfx::NativeWindow parent,
views::WidgetDelegate* delegate,
DialogStyle style) {
-#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
- // TODO(msw): revert to BubbleWindow for all ChromeOS cases when CL
- // for crbug.com/98322 is landed.
+#if defined(OS_CHROMEOS)
return chromeos::BubbleWindow::Create(parent, style, delegate);
#else
return views::Widget::CreateWindowWithParent(delegate, parent);

Powered by Google App Engine
This is Rietveld 408576698