Make BubbleWindow a Widget override with a BubbleFrameView.

Make BubbleWindow a Widget override with a BubbleFrameView.
Eliminate NativeWidgetGtk specifics, remove extra files.

This supersedes http://codereview.chromium.org/8811001/
This supersedes http://codereview.chromium.org/8774022/

See Issue 106230 for a list of some BubbleWindow users.
The save and open SelectFileExtensionDialog instances look good.
Bookmark All Tabs dialog looks good on non-aura, blocked on aura by crbug.com/106474.

BUG=106230
TEST=BubbleWindows look the same on CrOS, and now similar on Aura. Ensure no regressions of crosbug.com/9065, crosbug.com/8538.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113166

[msw, 2011-12-06 01:20:32]

PTAL; thanks! This should fix everything for Issue 106230.

[Emmanuel Saint-loubert-Bié, 2011-12-06 01:57:53]

lgtm

[Emmanuel Saint-loubert-Bié, 2011-12-06 02:47:17]

lgtm

Great job explain up that mess!

http://codereview.chromium.org/8800032/diff/4001/chrome/browser/ui/views/exte...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

http://codereview.chromium.org/8800032/diff/4001/chrome/browser/ui/views/exte...
chrome/browser/ui/views/extensions/extension_dialog.cc:77: style = STYLE_FLUSH;
Nit: in a case like this I prefer to have an #if #else #endif, rather than
setting a variable and changing right after (in the chromeos case).

[James Cook, 2011-12-06 04:41:06]

Michael, did you want me to review this?  I was OOO today, but I see you
included me on the reviewer list for http://codereview.chromium.org/8811001/

[James Cook, 2011-12-06 04:48:34]

I took a look anyway.  :-)  Nice cleanup. One strictly optional nit.  LGTM.

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/chromeos/fram...
File chrome/browser/chromeos/frame/bubble_window.h (right):

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/chromeos/fram...
chrome/browser/chromeos/frame/bubble_window.h:27: explicit
BubbleWindow(DialogStyle style);
nit: Maybe add a virtual destructor just to re-emphasize that this is a derived
class with virtual methods?

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/ui/views/wind...
File chrome/browser/ui/views/window.cc (right):

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/ui/views/wind...
chrome/browser/ui/views/window.cc:18: #endif  // OS_CHROMEOS
Thanks for commenting the #endif's -- I find this helps me a lot with nested
#defines.

[msw, 2011-12-06 06:05:14]

Thanks! I'll land with after trybots.

http://codereview.chromium.org/8800032/diff/4001/chrome/browser/ui/views/exte...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

http://codereview.chromium.org/8800032/diff/4001/chrome/browser/ui/views/exte...
chrome/browser/ui/views/extensions/extension_dialog.cc:77: style = STYLE_FLUSH;
On 2011/12/06 02:47:18, Emmanuel Saint-loubert wrote:
> Nit: in a case like this I prefer to have an #if #else #endif, rather than
> setting a variable and changing right after (in the chromeos case).

Done.

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/chromeos/fram...
File chrome/browser/chromeos/frame/bubble_window.h (right):

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/chromeos/fram...
chrome/browser/chromeos/frame/bubble_window.h:27: explicit
BubbleWindow(DialogStyle style);
On 2011/12/06 04:48:34, James Cook (Chromium) wrote:
> nit: Maybe add a virtual destructor just to re-emphasize that this is a
derived
> class with virtual methods?

Done.

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/ui/views/wind...
File chrome/browser/ui/views/window.cc (right):

http://codereview.chromium.org/8800032/diff/7001/chrome/browser/ui/views/wind...
chrome/browser/ui/views/window.cc:18: #endif  // OS_CHROMEOS
On 2011/12/06 04:48:34, James Cook (Chromium) wrote:
> Thanks for commenting the #endif's -- I find this helps me a lot with nested
> #defines.

:)

[commit-bot: I haz the power, 2011-12-06 07:32:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/8800032/10001

[commit-bot: I haz the power, 2011-12-06 09:16:48]

Change committed as 113166